Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obs4MIPs names to ESGF's in Schlund20esd recipe #3329

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Aug 14, 2023

Description

Following discussion here #2974

CERES-EBAF Ed2-7 is not available on ESGF anymore.
CERES-EBAF Ed2-8 is available for variable rlut, rlutcs, rsdt, rsut, rsutcs.
This PR removes the version facet for CERES-EBAF which fix automatic download from ESGF.

AIRS RetStd-v5 ['hus'] >> AIRS-2-1
AIRS-2-0 v2 ['hur'] >> AIRS-2-0
CERES-EBAF Ed2-7 >> CERES-EBAF
GPCP-SG v2.2 ['pr'] >> GPCP-V2.2


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

New or updated data reformatting script


To help with the number of pull requests:

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute! It looks like there is a small typo in the GPCP-V2.2 dataset name. It should be spelled with uppercase 'V'.

esmvaltool/recipes/recipe_schlund20esd.yml Outdated Show resolved Hide resolved
esmvaltool/recipes/recipe_schlund20esd.yml Outdated Show resolved Hide resolved
esmvaltool/recipes/recipe_schlund20esd.yml Outdated Show resolved Hide resolved
esmvaltool/recipes/recipe_schlund20esd.yml Outdated Show resolved Hide resolved
@rbeucher
Copy link
Contributor Author

rbeucher commented Nov 8, 2023

Thanks for pointing this out!

@bouweandela
Copy link
Member

Thanks for the updates! Could you please merge the main branch from this GitHub git repository into your branch? That should solve the failing tests. For example, if you have added this repository under the name upstream, you can do this by running the command git pull upstream main.

@zklaus zklaus dismissed bouweandela’s stale review November 9, 2023 13:38

Comments have been addressed.

@zklaus zklaus merged commit 1b435c5 into ESMValGroup:main Nov 9, 2023
6 checks passed
@schlunma schlunma changed the title Update obs4MIPs names to ESGF's in Schlunder20esd recipe Update obs4MIPs names to ESGF's in Schlund20esd recipe Nov 9, 2023
jvegreg pushed a commit that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants