Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recipe_carvalhais14: replace outline patch with splines #3111

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Mar 15, 2023

Description

Suggested by the legendary debugger @zklaus in #2886 (comment) - frankly, I've no idea why this was not PR-ed, or it was, why did it get reverted - but has been tested for v2.7.0 and was biutiful! Part of the mega effort by @remi-kazeroni in #3076


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@remi-kazeroni
Copy link
Contributor

@esmvalbot Please run recipe_carvalhais14nat.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 16, 2023

Since @remi-kazeroni asked, ESMValBot will run recipe recipe_carvalhais14nat.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Mar 16, 2023

ESMValBot is sorry to report it failed to run recipe recipe_carvalhais14nat.yml: exit is 1, output has been generated here

@remi-kazeroni
Copy link
Contributor

Note sure what's wrong with the bot not accessing our AUX files any more... Trying the recipe on Levante directly

@valeriupredoi
Copy link
Contributor Author

I am willing to eat my hat 🎩 if this doesn't fix the issue 😁

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valeriupredoi, you can keep your 🎩 on, the recipe runs fine now! Thanks a lot for the quick fix. Could someone please merge this?

@valeriupredoi
Copy link
Contributor Author

awesome, I like my heat on my head 🤣 @ESMValGroup/technical-lead-development-team one of you guys be a legend and merge this pls 🍺

@schlunma
Copy link
Contributor

Awesome, thanks both!!

@schlunma schlunma merged commit 97e118c into main Mar 16, 2023
@schlunma schlunma deleted the fix_recipe_carvalhais14 branch March 16, 2023 13:20
@valeriupredoi
Copy link
Contributor Author

cheers, Manu! I am already smelling the v2.8 stew 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants