Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests that use deprecated feature of sklearn #2961

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix failing tests that use deprecated feature of sklearn #2961

merged 1 commit into from
Dec 9, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Dec 9, 2022 •
edited by bouweandela
Loading

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

To help with the number of pull requests:

@schlunma schlunma added this to the v2.8.0 milestone Dec 9, 2022
@schlunma schlunma self-assigned this Dec 9, 2022
valeriupredoi
valeriupredoi approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak Sklearn API but tests are green so I'm not Skeptical 😁 Thanks, Manu! 🍺

@bouweandela bouweandela merged commit a56ce6e into main Dec 9, 2022
@bouweandela bouweandela deleted the fix_sklearn_test branch December 9, 2022 17:01
FranziskaWinterstein pushed a commit that referenced this pull request Dec 13, 2022
@schlunma @FranziskaWinterstein
Fix failing tests that use deprecated feature of sklearn (#2961)
e4aaed2
@schlunma schlunma mentioned this pull request Jan 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriupredoi valeriupredoi valeriupredoi approved these changes

@zklaus zklaus Awaiting requested review from zklaus

@bouweandela bouweandela Awaiting requested review from bouweandela

Assignees

@schlunma schlunma

Labels
testing
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

Tests for esmvaltool/diag_scripts/mlr failing
3 participants
@schlunma @valeriupredoi @bouweandela