-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCH4 ESA CMUG diagnostics (subset of the MPQB diagnostics) #1960
Conversation
Adding "nh", "sh" and the correct statistics description to the provenance.
Adding "nh" and "sh" to the provenance.
Adjusting the provenance caption as suggested.
|
@hb326 Thanks for working hard on this! I think most of the point I raised earlier are fine now. What I still fine a bit strange is the following in the provenance:
Other than that, I think all looks good! Nice work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Receipe runs fine, documentation and output look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! 🎉
I only have minor comments regarding the documentation, commented lines and specific plot labels.
Co-authored-by: Manuel Schlund <[email protected]>
Co-authored-by: Manuel Schlund <[email protected]>
Co-authored-by: Manuel Schlund <[email protected]>
Co-authored-by: Manuel Schlund <[email protected]>
Co-authored-by: Manuel Schlund <[email protected]>
Co-authored-by: Manuel Schlund <[email protected]>
Co-authored-by: Manuel Schlund <[email protected]>
Co-authored-by: Manuel Schlund <[email protected]>
Co-authored-by: Manuel Schlund <[email protected]>
Removing the "esm-hist" CMIP6 simulations from the recipe.
You were a little quick, @axel-lauer, with the merging. :) |
First diagnostic to use ESA CMUG XCH4 data for evaluating CMIP datasets.
Diagnostics are a subset of the C3S MPQB diagnostics, some with minor adjustments.
Checklist for technical review
yamllint
to check that your YAML files do not contain mistakesNew or updated recipe/diagnostic:
doc/sphinx/source/recipes
folder and an entry has been added toindex.rst
Automated checks pass, status can be seen below the pull request:
Details
link to find out why.Details
link to see it.Checklist for scientific review
New or updated recipe/diagnostic:
@esmvalbot
without any modifications to the recipe and with all data specified in the recipeIf you need help with any of the items on the checklists above, please do not hesitate to ask by commenting in the issue or pull request.
This pull request needs ESMValCore pull request 1428 (ESMValGroup/ESMValCore#1428) to be merged to be able to run the recipe.