-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added optimal install instructions for install from conda #1675
added optimal install instructions for install from conda #1675
Conversation
|
||
.. code-block:: bash | ||
|
||
ln -s $(pwd)/julia-*/bin/julia $(home)/miniconda3/bin/julia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This holds for the base environment, shouldn't this be: miniconda3/envs/esmvaltool/bin/
or another env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, you don't need to create an environment when installing directly from conda, it's just like installing any other software package by typing just one command (well, three commands in our case) 🍺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to try to link julia to the conda environment: so long as the julia
executable can be found in one of the directories listed in PATH
things should work fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to just point users to the site with the julia installation instructions: https://julialang.org/downloads/platform/ or https://julialang.org/downloads/platform/#linux_and_freebsd if we want to be specific. If these instructions change, ours will become outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, if those change we change the documentation too; man, a lot of the users prefer copy-paste instructions and going to see another set of instructions is already tedious for them 🍺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to try to link julia to the conda environment: so long as the
julia
executable can be found in one of the directories listed inPATH
things should work fine
correct! change that line if you think it's better to append to $PATH, man, up to you
by ESMValTool and its installation in advance of ``esmvaltool`` helps ``conda`` solve the | ||
environment much faster): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this works at the moment (see ESMValGroup/ESMValCore#660) this is usually not the most reliable way to install the package. There have been several occasions where conda failed to install esmvaltool into existing environments, because it was incompatible with the packages already installed and didn't know how to resolve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is not cool at all on conda's part because it should supersede those dependencies that are already installed from installing esmvalcore gah
@valeriupredoi I think this can be closed, because I added very similar instructions for installing julia in #1971 on your request. What do you think? |
yep we can bin it 🗑️ |
Before you start, read CONTRIBUTING.md and the guide for diagnostic developers.
Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.
Tasks
yamllint
to check that your YAML files do not contain mistakesNew recipe/diagnostic
doc/sphinx/source/recipes
folder and add a new entry to index.rstModified recipe/diagnostic
doc/sphinx/source/recipes
folderNew data reformatting script
Modified data reformatting script
If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
A lot of the discussion that led to this PR is here ESMValGroup/ESMValCore#660
@mattiarighi @bouweandela @jvegasbsc @schlunma need you guys to test the installation from conda (not from source) following these steps pls, can you pls use
\time
when running conda install, it'd be great to get a feel of how it performs on various platforms 🍺