Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRIMAVERA Energy budget #1286

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

PRIMAVERA Energy budget #1286

wants to merge 28 commits into from

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Sep 4, 2019 •
edited
Loading

New recipe/diagnostic

  • Add documentation for the recipe to the doc/sphinx/source/recipes folder and add a new entry to index.rst

Closes #210

@sloosvel sloosvel added PRIMAVERA Metric from the PRIMAVERA project diagnostic labels Sep 4, 2019
@sloosvel sloosvel marked this pull request as ready for review October 17, 2019 08:47
@bouweandela
Copy link
Member

Can you please merge the version2_development branch into this branch (or rebase onto it) so the unit tests do not fail on unrelated R code?

@mattiarighi mattiarighi changed the base branch from version2_development to master January 3, 2020 17:59
@bouweandela bouweandela mentioned this pull request Sep 24, 2020
Closed
@bouweandela
Copy link
Member

@sloosvel This pull request is not a draft, but not much has happened on it recently. Is it ready for review?

@sloosvel
Copy link
Contributor Author

I guess it needs some updating first, but this particular metric is not really used by anyone (is it worth it to merge @jvegasbsc ?). Also the plot looks a bit strange, but that is what the original code generates anyway.

@bouweandela bouweandela marked this pull request as draft February 10, 2021 08:40
@bouweandela
Copy link
Member

OK, I marked the pull request as draft for now, to indicate that it's still under development. Please mark it as 'Ready for review' once it's ready (if ever) 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouweandela bouweandela bouweandela left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
diagnostic PRIMAVERA Metric from the PRIMAVERA project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PRIMAVERA Energy budget and hydrological cycle
2 participants
@sloosvel @bouweandela