Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of the publication steps #984

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Feb 3, 2021

When preparing the release, we realized that some of the steps should be done in a different order. In particular, that we should do the code freeze before changing the release number and the changelog.

This PR is to fix that in the documentation

Before you get started

Checklist

If you make backwards incompatible changes to the recipe format:

  • Update ESMValTool and link the pull request(s) in the description

To help with the number pull requests:

@jvegreg jvegreg added the documentation Improvements or additions to documentation label Feb 3, 2021
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is something that bothered me about the previous releases and averts the issue with the dependency version conflict with ESMValTool but I forgot to ask @bouweandela why he was doing it this way

@bouweandela
Copy link
Member

I'm fine with either order. Don't forget to update the same text in the ESMValTool repo.

@valeriupredoi
Copy link
Contributor

@jvegasbsc merge at will mate, this would be nice to have in place for the next (2.2.1 or 2.3) release 👍

@jvegreg jvegreg merged commit baac058 into master Feb 9, 2021
@jvegreg jvegreg deleted the update_release_instructions branch February 9, 2021 08:53
jvegreg pushed a commit that referenced this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants