Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy 'engine' for multicube statistics #950

Closed
wants to merge 6 commits into from

Commits on Jan 18, 2021

  1. Configuration menu
    Copy the full SHA
    ac68794 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebccb16 View commit details
    Browse the repository at this point in the history
  3. Refactor multi_model_statistics

    Separate the ESMValCore internals, dealing with products, from
    the core function operating on cubes.
    
    This makes it easier to add a new preprocessor for ensemble statistics,
    and also to make a new core function (lazily) compute statistics
    across cubes.
    Peter9192 committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    4a66a72 View commit details
    Browse the repository at this point in the history
  4. Add alternative multi-cube statistics engine

    This function operates directly on iris cubes. It supports
    lazy evaluation, and requires less error-prone array handling.
    However, it requires the input cubes to be very homogeneous, so
    for backwards compatibility I kept the old function as well.
    
    This way we can easily test and improve the new function until
    we're happy, and then deprecate the old function.
    Peter9192 committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    b0ac09d View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Add regression tests for new multicube statistics function

    Currently the tests fail - as expected. Reasons are that
    'cell methods differ' or 'coordinates (time/air pressure) differ'.
    
    We can discuss whether this should be addressed within or outside
    of the multimodel/ensemble statistics funcions.
    Peter9192 committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    30096d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Configuration menu
    Copy the full SHA
    686a61d View commit details
    Browse the repository at this point in the history