-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added preprocessor mask_multimodel #767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me these changes look good. I also tested this preprocessor quite thoroughly by now, and it works as expected.
@schlunma you wanna switch this PR from Draft to RfR, mate? I'll haz a look right after you did that 👍 |
I still need to add tests and documentation for this, will do that this week/next week. After that I will switch the status of this PR 👍 |
rock on, dude! 🤘 |
This is ready for review now 👍 I added unit tests and documentation and also tested it on real data with the recipe mentioned in #487. All works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! a couple minor points inline, but also - could you pls add an integration test inside test_recipe
where you call the preprocessor and do some stuff with it? Cheers, dude 🍺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent stuff, cheers much @schlunma 🍺
This PR adds a working multimodel masking preprocessor.
The following things need to be implemented before the draft status can be cleared:
mask_multimodel
is the optimal choice.I probably do not have time to finish this soon, so any contributions to this PR are welcome!
Tasks
yamllint
to check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #487.