Suggested Documentation changes #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouweandela
reviewed
Jul 8, 2020
bouweandela
reviewed
Jul 8, 2020
bouweandela
reviewed
Jul 8, 2020
There was a problem hiding this comment.
Thank you for helping to improve the documentation! In case you missed it, you can preview what the changed documentation looks like by building the documentation locally. We're working on getting a preview available on-line too, but that doesn't work yet unfortunately.
bouweandela
reviewed
Jul 10, 2020
bouweandela
reviewed
Jul 10, 2020
Co-authored-by: Bouwe Andela <[email protected]>
Co-authored-by: Bouwe Andela <[email protected]>
Co-authored-by: Bouwe Andela <[email protected]>
|
@bouweandela I believe all comments above are implemented and text is consistent now from what I can tell. |
bouweandela
reviewed
Jul 10, 2020
Co-authored-by: Bouwe Andela <[email protected]>
mattiarighi
pushed a commit
that referenced
this pull request
Jul 13, 2020
* Remove utils section (#697) Moved the last script from esmvalcore/utils to ESMValTool * Fixed bug in time weights calculation (#695) * Fixed calculation of time weights * Fixed failing FLAKE8 test * Added more test for time weighting and fixed cube dimensions in test * Avoid pytest version that crashes (#707) * Suggested Documentation changes (#690) Update documentation on relative diagnostics paths and preprocessor order. Co-authored-by: Bouwe Andela <[email protected]> * Options arg in read_config_user_file now optional * Fix codacy warning Co-authored-by: Bouwe Andela <[email protected]> Co-authored-by: Manuel Schlund <[email protected]> Co-authored-by: Steve Smith <[email protected]> Co-authored-by: Bouwe Andela <[email protected]>
jvegreg
pushed a commit
that referenced
this pull request
Jul 16, 2020
* Remove utils section (#697) Moved the last script from esmvalcore/utils to ESMValTool * Fixed bug in time weights calculation (#695) * Fixed calculation of time weights * Fixed failing FLAKE8 test * Added more test for time weighting and fixed cube dimensions in test * Avoid pytest version that crashes (#707) * Suggested Documentation changes (#690) Update documentation on relative diagnostics paths and preprocessor order. Co-authored-by: Bouwe Andela <[email protected]> * Options arg in read_config_user_file now optional * Fix codacy warning Co-authored-by: Bouwe Andela <[email protected]> Co-authored-by: Manuel Schlund <[email protected]> Co-authored-by: Steve Smith <[email protected]> Co-authored-by: Bouwe Andela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few documentation suggestions, mentioned in:
Issue #1684
Closes ESMValGroup/ESMValTool#1684