-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preprocessor module to compute and store ACSIS indicators #638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
requested review from
bouweandela,
jvegreg,
mattiarighi and
ed-hawkins
May 15, 2020 11:44
valeriupredoi
added
enhancement
New feature or request
preprocessor
Related to the preprocessor
labels
May 15, 2020
closing this due to inactivity, but not deleting the branch just in case this will be revived 👻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you start, please read CONTRIBUTING.md.
Tasks
yamllint
to check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes {Link to corresponding issue}
SUMMARY
Compute and store ACSIS indicators as presented to me by @ed-hawkins - this is done now in a nice way via a preprocessor module with minimum effort and input from the user; the way they can invoke it is via an entry in the recipe:
note that files can be stored and read from by the code from the
auxiliary_data_dir
and also the variables can be anything the user wishes and if they are not specified then the defaults aremoc_mar_hc10
andUM_0_fc8_vn405
; the module computes the currently implemented ACSIS indicators and attaches them to the OBS6 file that were computed with as attributes.TODO (still)
I need to improve testing and write documentation.