Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved and completed time preprocessors list (PR 439 child 1) #508

Merged
merged 2 commits into from
Feb 21, 2020

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Feb 21, 2020

Before you start, please read CONTRIBUTING.md.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


This alleviates some of the burden from PR #439 that will be now be broken into smaller bits - this is the first child

@valeriupredoi valeriupredoi changed the title Moved and completed time preprocessors list (PR 439 child) Moved and completed time preprocessors list (PR 439 child 1) Feb 21, 2020
@valeriupredoi
Copy link
Contributor Author

hey guys @bouweandela @schlunma @zklaus can I get a quick approval on this one so I can merge in master and go on producing #439 children pls? 🍺

@zklaus
Copy link

zklaus commented Feb 21, 2020

PS: It would have been helpful to have a sentence in the PR description on what this is trying to achieve. I was able to deduce it from the code only because it was so small and well-written.

@valeriupredoi
Copy link
Contributor Author

cheers boss! 🍺

@valeriupredoi
Copy link
Contributor Author

I will add plenty of info to the other ones, gimme a sec, merge this in the next now 🚜

@valeriupredoi valeriupredoi merged commit 637bd47 into master Feb 21, 2020
@valeriupredoi valeriupredoi deleted the PR439_child1_time_preprocs branch February 21, 2020 15:54
@schlunma schlunma added this to the IPCC AR6 milestone Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants