Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow Ofx or Omon volcello data in recipe.py #429

Closed
wants to merge 8 commits into from

Conversation

ledm
Copy link
Contributor

@ledm ledm commented Jan 14, 2020

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes {https://github.com/ESMValGroup/ESMValCore/issues/405}

@ledm
Copy link
Contributor Author

ledm commented Jan 14, 2020

I guess @valeriupredoi shouldn't be a reviewer, as he wrote the code we're changing.

@valeriupredoi
Copy link
Contributor

yes but @predoivaleriu can 😁
@mattiarighi -> @ledm has tested this 🍺

@valeriupredoi
Copy link
Contributor

related (but not functionally per se) to #432 - I reckon we should get this one in first then #432 immediately after 🍺

@schlunma
Copy link
Contributor

superseded by #432

@schlunma schlunma closed this Jan 17, 2020
@schlunma schlunma deleted the development_cmip6_Ofx_Omon_fix branch January 17, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants