-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix time bounds in daily and monthly statistics #399
Conversation
nice one! can you please add a note in the docstrings and in the documentation about this, it's useful for users to know what they get out of this 😁 |
The notes are added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, cheers @SarahAlidoost 🍺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really convinced that this is the right approach. The computed time points do correspond to the average of the input time points used to compute the statistic, e.g. to get the daily statistic, data from time points 0...23 hour is used, resulting in 11.5 hour as the average time point. See also the discussion in #398
@SarahAlidoost do you want to update this given @bouweandela's comment above? |
Closing this pull request for now. Let's first continue the discussion in the issue and then a new pull request can be opened if needed. |
Before you start, please read CONTRIBUTING.md.
Tasks
yamllint
to check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #398