Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix time bounds in daily and monthly statistics #399

Closed
wants to merge 2 commits into from

Conversation

SarahAlidoost
Copy link
Contributor

@SarahAlidoost SarahAlidoost commented Dec 12, 2019

Before you start, please read CONTRIBUTING.md.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #398

@valeriupredoi
Copy link
Contributor

nice one! can you please add a note in the docstrings and in the documentation about this, it's useful for users to know what they get out of this 😁

@SarahAlidoost
Copy link
Contributor Author

nice one! can you please add a note in the docstrings and in the documentation about this, it's useful for users to know what they get out of this

The notes are added.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, cheers @SarahAlidoost 🍺

@mattiarighi mattiarighi added the preprocessor Related to the preprocessor label Dec 19, 2019
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really convinced that this is the right approach. The computed time points do correspond to the average of the input time points used to compute the statistic, e.g. to get the daily statistic, data from time points 0...23 hour is used, resulting in 11.5 hour as the average time point. See also the discussion in #398

@mattiarighi
Copy link
Contributor

@SarahAlidoost do you want to update this given @bouweandela's comment above?

@bouweandela
Copy link
Member

Closing this pull request for now. Let's first continue the discussion in the issue and then a new pull request can be opened if needed.

@bouweandela bouweandela deleted the fix_daily_statistics branch August 14, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time values after daily_statistics (or monthly_statistics)
4 participants