-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -i option in rerun message to ignore existing output directories #326
Conversation
related to ESMValGroup/ESMValTool#1271 The implementation from |
@valeriupredoi So far the only repercussion I see is the overwriting of previous results, but it is a clear consequence of the fact that a user wants to re-run the diagnostic. This should simply make more easy to copy and paste the commands to re-run the code ... am I missing something else? |
@tomaslovato yep that's it! But what I suggested was to add a line in the stdout message to tell the user that stuff will be overwritten and point them to the documentation ie line 432: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current re-run message is a good default, because it's safe. I agree that it would be nice to mention the other options, but I would prefer a log message instead of changing the default. Maybe something like:
if self.script.lower().endswith('.py'):
logger.info("Add the flag --help to the command for re-running the diagnostic script to see the available options for overwriting/ignoring previous results.")
closed via ESMValGroup/ESMValTool#1317 |
In relation to the error described in issue #136
I report here a small change to improve the usability of the tool when re-running diagnostics.
Tasks
yamllint
to check that your YAML files do not contain mistakesCloses #136