Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retire Mambaforge #2556

Merged
merged 4 commits into from
Oct 16, 2024
Merged

retire Mambaforge #2556

merged 4 commits into from
Oct 16, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 16, 2024

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added documentation Improvements or additions to documentation testing labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (1227b2f) to head (bfc2ca5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2556   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         251      251           
  Lines       14268    14268           
=======================================
  Hits        13557    13557           
  Misses        711      711           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bettina-gier bettina-gier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, technically equivalent to Tool pull request.

I think we got some more mambaforge references in the Tool quickstart install page and a mention in utilities though, as path suggestions. Probably should purge those.

@valeriupredoi
Copy link
Contributor Author

thank you @bettina-gier - yes, I missed a few mambaforge's in Tool in the Circle config and RTD config, will go fix those there too; just looking for the correct container name for RTD here, then will merge, cheers 🍺

@valeriupredoi
Copy link
Contributor Author

OK it appears the RTD configuration is still dependent on Mambaforge, and they don't yet offer a Miniforge3 variant, I'll merge this for now, and will open an issue that we have to fix RTD configuration with Miniforge when it becomes available from RTD, see readthedocs/readthedocs.org#11690

@valeriupredoi valeriupredoi merged commit 1279874 into main Oct 16, 2024
7 checks passed
@valeriupredoi valeriupredoi deleted the retire_Mambaforge branch October 16, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants