-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retire Mambaforge #2556
retire Mambaforge #2556
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2556 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 251 251
Lines 14268 14268
=======================================
Hits 13557 13557
Misses 711 711 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, technically equivalent to Tool pull request.
I think we got some more mambaforge references in the Tool quickstart install page and a mention in utilities though, as path suggestions. Probably should purge those.
thank you @bettina-gier - yes, I missed a few mambaforge's in Tool in the Circle config and RTD config, will go fix those there too; just looking for the correct container name for RTD here, then will merge, cheers 🍺 |
OK it appears the RTD configuration is still dependent on Mambaforge, and they don't yet offer a Miniforge3 variant, I'll merge this for now, and will open an issue that we have to fix RTD configuration with Miniforge when it becomes available from RTD, see readthedocs/readthedocs.org#11690 |
Description
mambaforge
container needs be changed from Readthedocs' build configuration - problem is, RTD don't support Miniforge3 https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python - will see what I can do - for now I opened an issue at RTD Build: retire Mambaforge (deprecated) and replace it with Miniforge3 readthedocs/readthedocs.org#11690Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: