Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous lazy preprocessor improvements #2520

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Sep 10, 2024

Description

Various improvements to the preprocessor functions related to handling lazy data.

Related to #674

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (a328578) to head (a4139bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
- Coverage   94.66%   94.66%   -0.01%     
==========================================
  Files         251      251              
  Lines       14287    14296       +9     
==========================================
+ Hits        13525    13533       +8     
- Misses        762      763       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela added preprocessor Related to the preprocessor dask related to improvements using Dask labels Sep 11, 2024
@bouweandela bouweandela marked this pull request as ready for review October 14, 2024 16:05
@valeriupredoi
Copy link
Contributor

@bouweandela this is a lovely PR - did you want to still work on it? It's been a while since it's been sitting out, let's get it in if you done working on it 🍺

@bouweandela
Copy link
Member Author

bouweandela commented Nov 13, 2024

It's ready for review. I would like to add more tests, but I'm not sure when I'll have time to do that, so maybe it's better to just go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask related to improvements using Dask preprocessor Related to the preprocessor
Development

Successfully merging this pull request may close these issues.

2 participants