Fix regridding issue where target grid is more than 2D #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouweandela
added
bug
Codecov Report
@@ Coverage Diff @@
## main #2087 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 237 237
Lines 12785 12793 +8
=======================================
+ Hits 11901 11909 +8
Misses 884 884
|
zklaus
reviewed
Jun 8, 2023
valeriupredoi
requested changes
Jun 8, 2023
There was a problem hiding this comment.
cheers, bud! A couple of minor points from me, but am requesting changes for @zklaus 's point to be considered (don't think he did review with req'd changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #968 a rechunking step was introduced if the target grid resolution was considerably higher than the source grid. However, it failed to take into account that the target grid could have more dimensions than just latitude and longitude. This pull request fixes the issue.
Closes #2085
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: