Sort missing years in "No input data available for years" message #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledm
changed the title
ledm
commented
Jul 13, 2021
|
@ledm please don't review your own PR, I know you want to make code changes straight in the web editor but do it via the edit code option not via review, reviewing your own PR adds confusion at review stage 🍺 |
jvegreg
requested changes
Jul 14, 2021
|
@ledm, can you also update it with the latest changes on main? It should fix the CircleCI error |
Co-authored-by: Javier Vegas-Regidor <[email protected]>
…no-input-available-for-years
Done! |
jvegreg
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1225 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 188 188
Lines 9150 9150
=======================================
Hits 7827 7827
Misses 1323 1323
Continue to review full report at Codecov.
|
jvegreg
approved these changes
Jul 14, 2021
zklaus
pushed a commit
that referenced
this pull request
Jul 21, 2021
) * added a sorted print statement. * Update esmvalcore/_recipe_checks.py * Update esmvalcore/_recipe_checks.py Co-authored-by: Javier Vegas-Regidor <[email protected]> * Fix failing test Co-authored-by: Javier Vegas-Regidor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1224
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: