-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert multimodel module to v2.2.0 #1202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not decided to revert this module just yet.
indeed, we need to reach a decision on this, I suggest we do it soon so we know which way we go 👍 |
Codecov Report
@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
- Coverage 85.51% 85.50% -0.02%
==========================================
Files 188 188
Lines 9147 9161 +14
==========================================
+ Hits 7822 7833 +11
- Misses 1325 1328 +3
Continue to review full report at Codecov.
|
heads up we should close this if no revert is decided to be needed @zklaus |
Cheers for the heads-up, V. I have it on the radar (now the milestone as well). Revert is still a possibility imho until the ancillary variables issue is resolved, so let's keep it open for now. Having it on the 2.3.1 milestone makes sure we don't just forget it. |
Issues dealt with elsewhere, see ESMValGroup/ESMValTool#2218. |
Description
DO NOT MERGE JUST YET - I need to create a clone of current
main
so we don't lose the current MM moduleCloses #1201
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: