pin cf-units, remove github actions test for Python 3.6 and fix test_access1_0 and test_access1_3 to use cf-units for comparisons #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1197 +/- ##
=======================================
Coverage 85.51% 85.51%
=======================================
Files 188 188
Lines 9147 9147
=======================================
Hits 7822 7822
Misses 1325 1325 Continue to review full report at Codecov.
|
valeriupredoi
changed the title
4 tasks
3 tasks
zklaus
approved these changes
Jul 7, 2021
zklaus
pushed a commit
that referenced
this pull request
Jul 7, 2021
…access1_0 and test_access1_3 to use cf-units for comparisons (#1197) * fix test with cf units * fix test with cf units * test fully on GA * no need to import * pin cf units * pin cf units * pin cf units * retire python 36 * remove GA test branch
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cf-unitswent up to 3.0.0 and this broke the tests again, now we have use ofcf-unitsfor both reference and test datescf-units=2.1.5throws a very dubious error when comparing datetimes as we do in those tests, and 3.0.0 doesn't have a packaging for Python 3.6Closes #issue_number
Link to documentation:
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: