Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMOR fixes for HadREM3-GA7-05 #1062

Closed
wants to merge 2 commits into from
Closed

CMOR fixes for HadREM3-GA7-05 #1062

wants to merge 2 commits into from

Conversation

thomascrocker
Copy link
Contributor

CMOR fixes for HadREM3-GA7-05 CORDEX data. Follows similar approach to fixes for HadGEM2-ES etc.

Before you get started

Checklist

If you make backwards incompatible changes to the recipe format:

  • Update ESMValTool and link the pull request(s) in the description

To help with the number pull requests:

@thomascrocker thomascrocker added fix for dataset Related to dataset-specific fix files cmor Related to the CMOR standard labels Mar 29, 2021
@thomascrocker thomascrocker self-assigned this Mar 29, 2021
@thomascrocker
Copy link
Contributor Author

My first pull request. Feel free to assign me to review any other PRs if it would be useful.

@valeriupredoi
Copy link
Contributor

cheers @thomascrocker I'll have a looksee later today 👍

valeriupredoi
valeriupredoi requested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor Codacy issues. @jvegasbsc and @zklaus will know about CORDEX, I have very limited knowledge of that dataset unfortunately

esmvalcore/cmor/_fixes/cordex/hadrem3_ga7_05.py Outdated Show resolved Hide resolved
esmvalcore/cmor/_fixes/cordex/hadrem3_ga7_05.py Outdated Show resolved Hide resolved
@thomascrocker @valeriupredoi
Apply suggestions from code review
c80b7e9 
Amended descriptions

Co-authored-by: Valeriu Predoi <[email protected]>
@thomascrocker thomascrocker mentioned this pull request May 25, 2021
Open
@nhsavage
Copy link

how do we get this PR moving again please? should we do a new PR to check if it will merge to the latest head? What needs to be done to resolve the Codacy Static Code Analysis problems?

@remi-kazeroni
Copy link
Contributor

@zklaus, what are these Trello notifications that we are getting from your account? Are these accidental?

@zklaus
Copy link

zklaus commented Jun 29, 2022

Oh sorry guys, I just started using trello to organize my own ESMValTool work. I did not realize that the "Power-Up" I was using would place a backlink here.

Please disregard

PS: And now I found the switch to avoid that 🤦

@zklaus
Copy link

zklaus commented Jun 29, 2022 •
edited
Loading

@nhsavage, sorry, the trello board is intended for my personal work only, the link was placed here in error.

@sloosvel
Copy link
Contributor

This fix got included in #1765

@sloosvel sloosvel closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriupredoi valeriupredoi valeriupredoi requested changes

@zklaus zklaus Awaiting requested review from zklaus

@jvegreg jvegreg Awaiting requested review from jvegreg

Assignees

@thomascrocker thomascrocker

Labels
cmor Related to the CMOR standard fix for dataset Related to dataset-specific fix files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataset problem: CMORCheckError for MOHC-HadREM3-GA7-05 CORDEX data. (Wrong latitude and longitude names)
6 participants
@thomascrocker @valeriupredoi @nhsavage @remi-kazeroni @zklaus @sloosvel