Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to original Github Actions test workflow removing the 3-hourly test run with -n 1 #1025

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Revert to original Github Actions test workflow removing the 3-hourly test run with -n 1 #1025

merged 1 commit into from
Mar 1, 2021

Conversation

valeriupredoi
Copy link
Contributor

reverts changes that supported the (now false supposition) tests pass w/o SegFaults if run in single thread mode from #1020

@valeriupredoi valeriupredoi mentioned this pull request Mar 1, 2021
Closed
stefsmeets
stefsmeets approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@stefsmeets stefsmeets left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easiest review ever 😁 Looks good, hope the tests were helpful!

@valeriupredoi
Copy link
Contributor Author

cheers mate @stefsmeets

@valeriupredoi valeriupredoi merged commit 1cbaa62 into master Mar 1, 2021
@valeriupredoi valeriupredoi deleted the revert_run_GA_test_every3h branch March 1, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefsmeets stefsmeets stefsmeets approved these changes

@bouweandela bouweandela Awaiting requested review from bouweandela

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valeriupredoi @stefsmeets