Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend preprocessor multi_model_statistics to handle data with "altitude" coordinate #1010

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

axel-lauer
Copy link
Contributor

@axel-lauer axel-lauer commented Feb 19, 2021

This PR extends the preprocessor multi_model_statistics to allow handling of data with a vertical corrdinate "altitude".


Before you get started

Checklist

If you make backwards incompatible changes to the recipe format:

  • Update ESMValTool and link the pull request(s) in the description

To help with the number pull requests:

@axel-lauer axel-lauer added bug Something isn't working preprocessor Related to the preprocessor labels Feb 19, 2021
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion attached. Tested successfully with real data 👍

This is only a temporary solution, but since the multi_model_statistics preprocessor will be lazy soon and hopefully support arbitrary input dimensions (#968), I guess we can merge this small workaround as is.

esmvalcore/preprocessor/_multimodel.py Show resolved Hide resolved
@axel-lauer axel-lauer merged commit 197324b into master Feb 19, 2021
@axel-lauer axel-lauer deleted the fix_multimodel_altitude branch February 19, 2021 13:31
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @axel-lauer - please add relevant review labels next time, gonna add the passed tech review now - nevermind, we don't have them in Core 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preprocessor multi_model_statistics cannot handle altitude coordinate
3 participants