Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not report memcomp if no baseline exists #4691

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

jedwards4b
Copy link
Contributor

@jedwards4b jedwards4b commented Oct 8, 2024

This PR changes the test error:
FAIL SMS_D_Ld3_PS.f09_g17.I1850Clm60SpNoAnthro.derecho_intel.clm-decStart1851_noinitial--clm-nofireemis MEMCOMP [Errno 2] No such file or directory: '/glade/campaign/cesm/cesmdata/cesm_baselines/cesm3_0_beta03/SMS_D_Ld3_PS.f09_g17.I1850Clm60SpNoAnthro.derecho_intel.clm-decStart1851_noinitial--clm-nofireemis/cpl-mem.log' and does not report
MEMCOMP if no baseline cpl-mem.log exists.

Test suite: scripts_regression_tests.py, cesm prealpha
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #4590

User interface changes?: N

Update gh-pages html (Y/N)?:

@jedwards4b jedwards4b self-assigned this Oct 8, 2024
@jedwards4b
Copy link
Contributor Author

@jasonb5 I'm not sure if it would be better to somehow report MEMCOMP but not fail and not pass or just not report if there is no baseline file present. I chose not to report just because that's easier.

@jedwards4b jedwards4b mentioned this pull request Oct 9, 2024
@jasonb5
Copy link
Collaborator

jasonb5 commented Oct 9, 2024

@jedwards4b I think it's probably fine to not report if there is no baseline, just need to test the behavior.

@jasonb5
Copy link
Collaborator

jasonb5 commented Oct 10, 2024

@rljacob @jgfouca I tested this and if the the baseline files are missing then the phase (MEMCOMP, TPUTCOMP) is omitted from the TestStatus file. If the memory baseline is missing then the MEMCOMP is omitted but the MEMLEAK is still included. I'm wondering if as an alternative to omitting it might be better to introduce a new status of IGNORE or SKIP when the baseline is missing? Or are we ok with the phases being omitted?

@rljacob
Copy link
Member

rljacob commented Oct 10, 2024

omitted is fine with me.

Copy link
Collaborator

@jasonb5 jasonb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedwards4b jedwards4b merged commit 4de5fc2 into ESMCI:master Oct 10, 2024
7 checks passed
@jedwards4b jedwards4b deleted the fix/memlog_no_baseline branch October 10, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpl-mem.log not being created for short tests
3 participants