-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes exception from xmlchange #4631
Conversation
@jasonb5 that solved the first problem but I am still seeing:
I think that I have a fix for this and will push it back if that's okay? |
@jedwards4b Go ahead and push your fix. |
@jasonb5 based on this result I am ready to merge this PR. |
I'll have to double check - I realized that #4631 fixed the github testing and that I needed that more urgently than testing on derecho or perlmutter. I think there are still some issues that need to be addressed there, but I'm not sure if this is one of them. |
The
xmlchange
tool should not raise an exception when a diff is detected.Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Fixes [CIME Github issue #]
User interface changes?:
Update gh-pages html (Y/N)?: