Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes exception from xmlchange #4631

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Fixes exception from xmlchange #4631

merged 6 commits into from
Jun 13, 2024

Conversation

jasonb5
Copy link
Collaborator

@jasonb5 jasonb5 commented May 15, 2024

The xmlchange tool should not raise an exception when a diff is detected.

Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]
User interface changes?:
Update gh-pages html (Y/N)?:

@jedwards4b
Copy link
Contributor

@jasonb5 that solved the first problem but I am still seeing:

======================================================================
FAIL: test_e_xmlquery (test_sys_create_newcase.TestCreateNewcase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/glade/work/jedwards/sandboxes/cesm2_x_alpha/cime/CIME/tests/test_sys_create_newcase.py", line 321, in test_e_xmlquery
self.assertTrue(output == "TRUE", msg="%s != %s" % (output, BUILD_COMPLETE))
AssertionError: False is not true : FALSE != False

----------------------------------------------------------------------

I think that I have a fix for this and will push it back if that's okay?

@jasonb5
Copy link
Collaborator Author

jasonb5 commented May 15, 2024

@jedwards4b Go ahead and push your fix.

@jedwards4b
Copy link
Contributor

@jasonb5 based on this result I am ready to merge this PR.

@jedwards4b jedwards4b self-requested a review June 12, 2024 22:11
@jasonb5 jasonb5 merged commit f903115 into master Jun 13, 2024
7 checks passed
@jasonb5 jasonb5 deleted the fix-quiet-lockedfiles branch June 13, 2024 15:57
@jedwards4b
Copy link
Contributor

I'll have to double check - I realized that #4631 fixed the github testing and that I needed that more urgently than testing on derecho or perlmutter. I think there are still some issues that need to be addressed there, but I'm not sure if this is one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants