Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to get PRE test working on ADESP_TEST on Cheyenne #1787

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

gold2718
Copy link

@gold2718 gold2718 commented Aug 2, 2017

Modified PRE test to look for no pause signal situation.
Modified ADESP_TEST variable change to get output change with new docn aquaplanet.
Added ADESP_TEST to cime_developer suite.

Test suite: scripts_regression_tests.py on Yellowstone, Cheyenne, and Hobart
Test baseline: NA
Test namelist changes: NA
Test status: bit for bit

Fixes #1622

User interface changes?: No

Update gh-pages html (Y/N)?: N

Code review:

Added ADESP_TEST to cime_developer suite
Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should remove the loglevel requirement and always write these messages to the desp log. If you agree could you do another PR with that change?

@@ -427,6 +427,13 @@ subroutine desp_comp_run(EClock, case_name, pause_sig, atm_resume, &

call t_startf('desp_mode')

if (.not. ANY(pause_sig)) then
if ((my_task == master_task) .and. (loglevel > 0)) then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the loglevel requirement in this and other locations in desp and just allways write these messages to the desp.log?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for this warning, what others? Check:
Lines 505, 512, 562, and 676

@jedwards4b jedwards4b merged commit c4d50cc into ESMCI:master Aug 2, 2017
@gold2718 gold2718 deleted the PreFix branch August 2, 2017 19:47
@jedwards4b
Copy link
Contributor

I would say all of them, it's not an over abundance of output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants