Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CESM's rof2ocn liquid maps likely have incorrect mask_b and frac_b #2010

Closed
billsacks opened this issue Oct 31, 2017 · 2 comments
Closed

CESM's rof2ocn liquid maps likely have incorrect mask_b and frac_b #2010

billsacks opened this issue Oct 31, 2017 · 2 comments
Assignees
Labels
Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM st: wontfix tp: config ty: Bug

Comments

@billsacks
Copy link
Member

Due to #2009 @mnlevy1981 and I feel that we should remake all of CESM's rof2ocn liquid maps (once #2009 is fixed). For at least one case, we should then check if this changes answers at all - i.e., whether the old, buggy mask_b and frac_b had any impact on the system.

@billsacks billsacks added Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM tp: config ty: Bug labels Oct 31, 2017
@alperaltuntas alperaltuntas self-assigned this Nov 3, 2017
@alperaltuntas
Copy link
Member

I generated two sets of rx1->gx37 maps: (1) using the mapping tool without the latest fixes, and (2) using the mapping tool with the latest fixes (#2007 #2013 #2022). I ran C cases with both maps and compared the results. It appears that answers do NOT change, so I think it's not necessary to remake rof2ocn liq maps. (Answer changes I saw earlier were because I have not specified the coastal grid files in nml file for the map generating tool, and so the nearest neighbor mappings were not confined to the coast.)

@billsacks
Copy link
Member Author

Thanks for checking. That's a relief.

billsacks pushed a commit to billsacks/cime that referenced this issue Jan 11, 2018
…SMCI#2010)

Make Intel 18 the default for cori-knl.  Make KNL nodes the default on Cori.
jgfouca pushed a commit that referenced this issue Feb 23, 2018
…2010)

Make Intel 18 the default for cori-knl.  Make KNL nodes the default on Cori.
jgfouca pushed a commit that referenced this issue Mar 13, 2018
…2010)

Make Intel 18 the default for cori-knl.  Make KNL nodes the default on Cori.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM st: wontfix tp: config ty: Bug
Projects
None yet
Development

No branches or pull requests

2 participants