Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pes specification file wrong in README.case for case with a compset alias and --pesfile #1664

Closed
billsacks opened this issue Jun 9, 2017 · 0 comments

Comments

@billsacks
Copy link
Member

If you create a case with a compset alias using the --pesfile argument, README.case says:

2017-06-08 20:42:01: Pes     specification file is unset

rather than pointing to the --pesfile you gave.

I'm fixing this in an upcoming PR.

@billsacks billsacks self-assigned this Jun 9, 2017
jedwards4b added a commit that referenced this issue Jun 9, 2017
User compset fixes
Main change is to have user-defined compsets still pick up a usermods
directory under [primary_component]/cime_config/usermods_dirs/. Along
with this, I have refactored where some other things are set that depend
on primary component. A key aim here was to have various things set in
the same place regardless of whether we're using a compset with or
without an alias. I find this makes it easier to understand the code,
and less likely to introduce discrepancies between user-defined and
alias-defined compsets in the future.

Test suite: scripts_regression_tests on yellowstone
Also, manual testing:

Compset with an alias: picks up PE settings and a usermods directory
User compset picks up PE settings
User compset picks up usermods directory, as in:
./create_newcase --case no_alias_0608d --compset 1850_DATM%GSWP3v1_CLM50%BGC-CROP_SICE_SOCN_RTM_CISM2%NOEVOLVE_SWAV --res f09_g16 --user-compset --user-mods-dir clm/clm5_OutputCrop
Test baseline: N/A
Test namelist changes: none
Test status: bit for bit
Fixes #1658
Fixes #1664
Fixes #1665

User interface changes?: none

Code review:jedwards
@ghost ghost removed the in progress label Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant