Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

are externals genf90 and CMake still external? #1637

Closed
rljacob opened this issue Jun 3, 2017 · 4 comments
Closed

are externals genf90 and CMake still external? #1637

rljacob opened this issue Jun 3, 2017 · 4 comments

Comments

@rljacob
Copy link
Member

rljacob commented Jun 3, 2017

Is the code in src/externals/genf90 and src/externals/CMake still maintained as externals? That is, do we ever try to update from or make PRs to the upstream masters for those codes? Or are the versions in this repo now the master?

CMake upstream master: https://github.com/CESM-Development/CMake_Fortran_utils
genf90 upstream master: https://github.com/PARALLELIO/genf90

@billsacks
Copy link
Member

For CMake_Fortran_utils, we're no longer treating this as an external as far as I know, so in my view this could be moved fully into cime (I just don't know the process for doing that).

I can't speak to genf90.

@jedwards4b
Copy link
Contributor

genf90 is used and maintained by PIO and so is a valid external.

@rljacob
Copy link
Member Author

rljacob commented Jun 6, 2017

Ok.

Since its a subtree, all we have to do for CMake is move its directory out of "externals"

@rljacob
Copy link
Member Author

rljacob commented Jul 6, 2017

Question answers and new issue opened.

@rljacob rljacob closed this as completed Jul 6, 2017
jgfouca pushed a commit that referenced this issue Oct 17, 2017
…yout (PR #1637)

Default PE layout for F-compsets on Edison
jgfouca pushed a commit that referenced this issue Feb 23, 2018
…yout (PR #1637)

Default PE layout for F-compsets on Edison
jgfouca pushed a commit that referenced this issue Mar 13, 2018
…yout (PR #1637)

Default PE layout for F-compsets on Edison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants