Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid quotes in DROF namelist_defaults.xml valid_values #1577

Closed
mvertens opened this issue May 20, 2017 · 0 comments · Fixed by #1578
Closed

invalid quotes in DROF namelist_defaults.xml valid_values #1577

mvertens opened this issue May 20, 2017 · 0 comments · Fixed by #1578
Assignees

Comments

@mvertens
Copy link
Contributor

Invalid double quotes in the valid values settings for
taxmode, decomp,mapmask,mapalgo
need to be removed.

@mvertens mvertens self-assigned this May 20, 2017
billsacks added a commit that referenced this issue May 20, 2017
Rename DATM S1850 mode to CPLHIST

Use %CPLHIST for DATM coupler hist forcing

Coupler history forcing should have a %CPLHIST mode for any data component
that uses it. This change makes DATM conform to this convention.

It also fixes the invalid quotes in DROF valid values in #1577

Also changes strm_domdir to null for the cplhist streams: 
For CPLHIST you want to get the domain from the first stream
file. Its important the the stream domain match the stream data. So when
strm_domdir is null shr_strdata ensures that this is the case. This is also
happening rof the drof CPLHIST mode.

Also increases dtlimit to 3 in some places (it was 2 before): 
For the CPLHIST mode and the first time sample it
needs to be 3 - and we want this to work out of the box. 
It's okay that this loosens the error checking a bit:
It's a very large value - e.g. 100 that would be of concern.

Test suite: scripts_regression_tests
also verified that the following CESM spinup compset
1850_DATM%CPLHIST_SLND_CICE_POP2%ECO_DROF%CPLHIST_SGLC_WW3
gave the correct values
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1577 
Fixes #1576
User interface changes?: None
Code review: Bill Sacks
@ghost ghost removed the in progress label May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant