Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIME Users Guide Documentation #1519

Closed
bertinia opened this issue May 11, 2017 · 11 comments
Closed

CIME Users Guide Documentation #1519

bertinia opened this issue May 11, 2017 · 11 comments

Comments

@bertinia
Copy link
Contributor

bertinia commented May 11, 2017

I'm opening a new issue for the CIME Users Guide Documentation to coordinate
our efforts so that a technical writer at NCAR can review and update what is currently
posted at esmci.github.io/cime

Mariana sent out this email on 2-19-2017 with section assignments for the CIME Users Guide documentation on the gh-pages branch:

  • @ekluzek and @billsacks l - can you look at the data model introduction and streams file input summary. Bill: Done Intro; gave streams file input summary a quick read
  • @ekluzek - can you look at the data model datm section.
  • @billsacks - can you look at the data model dlnd land section. DONE
  • @dabail10 - can you please look at the data model docn and dice section.
  • @mnlevy1981 - can you please look at the data model drof section.
  • @jedwards4b - can you please look at the create_newcase and build sections in the user's guide.
  • @bertinia - can you please look at the run section in the user's guide. DONE

Please update this issue ticket with the status for your section assignment so I can
coordinate with the tech writer.

@bertinia bertinia added this to the cesm2 milestone May 11, 2017
@bertinia bertinia self-assigned this May 11, 2017
@dabail10
Copy link
Contributor

Things are looking good with DICE and DOCN that I can see. I have a few points though. The link to the SOM.pdf file is not working under the DOCN document. Also, it would be great to link to the bulletin board FAQ on this:

https://bb.cgd.ucar.edu/faq-data-ocean-slab-mode-docn-som

Also, I'm not sure about the convention for boldface, typewritten, italic. It looks like it is typewritten (double back quotes) for variables and file and directory names, but boldface (double asterixes) for some file and directory names. Is there a convention defined somewhere in the documentation? For the CICE User's Guide I do the following:

This document uses the following text conventions:
Variable names used in the code are typewritten.
Subroutine are given in italic.
File and directory names are in boldface.

Dave

@mnlevy1981
Copy link
Contributor

The river runoff section is done as of b675ad8

commit b675ad8855a8f330ac93a5a747017180ebd51ddd
Author: Michael Levy <[email protected]>
Date:   Mon Feb 20 11:10:43 2017 -0700

    Clean up DROF documentation
    
    Mostly formatting changes (removing trailing spaces, formatting tables better,
    etc) but also fixed some typos). I changed all instances of "xml variables" to
    "XML variables", and also removed the table from the "Fields" section because
    it looks better inline.

@billsacks
Copy link
Member

I still need to do some of this.... I updated the issue accordingly

@rljacob
Copy link
Member

rljacob commented Jul 5, 2017

General Update from CIME telecon: BJ Smith completed his technical writing. Alice has his notes for gaps. Need to add: how to generate grids, user compsets. Larger glossary.

@bertinia
Copy link
Contributor Author

@cacraigucar - moved you new issue #1764 as a comment on this open issue to keep all
CIME user's guides issues together.

The documentation (section 8.3) for creating a branch or hybrid run needs to be amended slightly. Right now it says to do a case.build prior to copying the restart files into the $RUNDIR. Since a preview_namelists is the first step of a case.build, this exits with a an error as the restart files are not found.

It also might be useful to describe briefly the difference between branch and hybrid on this page or have a link back to the descriptions in 6.3 for their definitions.

Also, when does a user want to use create_clone? The documentation on this is very sparse. A description on when to make a branch versus a clone would be useful.

For someone who is not "in the know" on hybrid/branch/clone, it was not very straightforward to work through this information.

@billsacks
Copy link
Member

@bertinia I realized I dropped the ball on my responsibilities here (with respect to the data models), but I want to wrap this up. Before I look back at this: Is there anything outstanding / in the works with respect to the data model documentation, or is this in a state that's good to review as far as you know? (I know there are some changes to the documentation with #1950, but do you know of any other changes underway?)

@bertinia
Copy link
Contributor Author

@billsacks - everything in master doc is up-to-date as far as I know w.r.t. the data models.
When you issue a PR associated with this open issue, just indicate that you would like the
the gh-pages orphan branch updated with the latest html.

@billsacks
Copy link
Member

In #1969 I have finally fulfilled my assignments. However, I only skimmed 'input-streams'... I made some light edits but did not spend a lot of time on that section.

Also, I noticed that the data-wave section 11.2 doesn't match the layout of other data models... I haven't fixed this.

@cacraigucar
Copy link
Contributor

@bertinia - I just looked at section 8 (create_clone) to help me with in setting up a create_clone run. It does not say what commands you need to issue after it and I needed to ask Jim. After speaking with him, case.setup is implied in a create_clone. A case.build needs to be run if --keepexe is not supplied. I would suggest having your examples (both with and without the --keepexe flag) include the ./case.submit step. In the first example without the --keepexe flag, you also need to add the ./case.build step to the example.

@cacraigucar
Copy link
Contributor

./cime/config needs to be documented somewhere with the list of useful variables and needs to be updated with new variables as they are added (like the email selector)

jgfouca added a commit that referenced this issue Dec 8, 2017
…branch-for-to-acme-12-06-2017-pr

* commit '530c337666de1af28698c74b9e58e8baf93a6bbf':
  fix issue in scripts_regression_tests
  Add ability to customize CaseStatus success message for a phase.
  Fix bug in compare namelists
  add test for xmlquery DOCN_MODE
  Fix memory leak of newtimers in merge_thread_data
  in splitting comp vars make sure comp isnt subset of name
  Update ChangeLog
  nthrds > 1 should set build_threaded flag
  Update ChangeLog
  Update ChangeLog
  fix pylint issue
  fix gptl threaded build, batch change for cheyenne
  correct path for includes used in build
  Check for unicode in expect()
  update ACME to E3SM and changes related to Issue #1519 and PR #2062
  Do not use normalization when mapping glc2ocn
  Add comments about not needing to add fields to x2o_fluxes and x2i_fluxes
  Point to new glc2ocn mapping files
  Allow different glc2ocn mappings for liq and ice
jgfouca added a commit that referenced this issue Dec 8, 2017
#1963)

Fixes:

* DOCN_MODE fix for xmlchange
* compare_namelist bug in rare code path
* Fix memleak in gptl
* Fix setting of build_threaded
* Fix unicode problems with expect

Feature list:
* Add job-id info for CaseStatus entry for job submit
* Allow different glc2ocn mappings for liq and ice

[BFB]

* jgfouca/branch-for-to-acme-12-06-2017-pr: (21 commits)
  Ignore buildlib python bytecode files
  This is no longer needed
  fix issue in scripts_regression_tests
  Add ability to customize CaseStatus success message for a phase.
  Fix bug in compare namelists
  add test for xmlquery DOCN_MODE
  Fix memory leak of newtimers in merge_thread_data
  in splitting comp vars make sure comp isnt subset of name
  Update ChangeLog
  nthrds > 1 should set build_threaded flag
  Update ChangeLog
  Update ChangeLog
  fix pylint issue
  fix gptl threaded build, batch change for cheyenne
  correct path for includes used in build
  Check for unicode in expect()
  update ACME to E3SM and changes related to Issue #1519 and PR #2062
  Do not use normalization when mapping glc2ocn
  Add comments about not needing to add fields to x2o_fluxes and x2i_fluxes
  Point to new glc2ocn mapping files
  ...
jgfouca added a commit that referenced this issue Feb 23, 2018
…branch-for-to-acme-12-06-2017-pr

* commit '530c337666de1af28698c74b9e58e8baf93a6bbf':
  fix issue in scripts_regression_tests
  Add ability to customize CaseStatus success message for a phase.
  Fix bug in compare namelists
  add test for xmlquery DOCN_MODE
  Fix memory leak of newtimers in merge_thread_data
  in splitting comp vars make sure comp isnt subset of name
  Update ChangeLog
  nthrds > 1 should set build_threaded flag
  Update ChangeLog
  Update ChangeLog
  fix pylint issue
  fix gptl threaded build, batch change for cheyenne
  correct path for includes used in build
  Check for unicode in expect()
  update ACME to E3SM and changes related to Issue #1519 and PR #2062
  Do not use normalization when mapping glc2ocn
  Add comments about not needing to add fields to x2o_fluxes and x2i_fluxes
  Point to new glc2ocn mapping files
  Allow different glc2ocn mappings for liq and ice
jgfouca added a commit that referenced this issue Feb 23, 2018
#1963)

Fixes:

* DOCN_MODE fix for xmlchange
* compare_namelist bug in rare code path
* Fix memleak in gptl
* Fix setting of build_threaded
* Fix unicode problems with expect

Feature list:
* Add job-id info for CaseStatus entry for job submit
* Allow different glc2ocn mappings for liq and ice

[BFB]

* jgfouca/branch-for-to-acme-12-06-2017-pr: (21 commits)
  Ignore buildlib python bytecode files
  This is no longer needed
  fix issue in scripts_regression_tests
  Add ability to customize CaseStatus success message for a phase.
  Fix bug in compare namelists
  add test for xmlquery DOCN_MODE
  Fix memory leak of newtimers in merge_thread_data
  in splitting comp vars make sure comp isnt subset of name
  Update ChangeLog
  nthrds > 1 should set build_threaded flag
  Update ChangeLog
  Update ChangeLog
  fix pylint issue
  fix gptl threaded build, batch change for cheyenne
  correct path for includes used in build
  Check for unicode in expect()
  update ACME to E3SM and changes related to Issue #1519 and PR #2062
  Do not use normalization when mapping glc2ocn
  Add comments about not needing to add fields to x2o_fluxes and x2i_fluxes
  Point to new glc2ocn mapping files
  ...
jgfouca added a commit that referenced this issue Mar 13, 2018
…branch-for-to-acme-12-06-2017-pr

* commit '530c337666de1af28698c74b9e58e8baf93a6bbf':
  fix issue in scripts_regression_tests
  Add ability to customize CaseStatus success message for a phase.
  Fix bug in compare namelists
  add test for xmlquery DOCN_MODE
  Fix memory leak of newtimers in merge_thread_data
  in splitting comp vars make sure comp isnt subset of name
  Update ChangeLog
  nthrds > 1 should set build_threaded flag
  Update ChangeLog
  Update ChangeLog
  fix pylint issue
  fix gptl threaded build, batch change for cheyenne
  correct path for includes used in build
  Check for unicode in expect()
  update ACME to E3SM and changes related to Issue #1519 and PR #2062
  Do not use normalization when mapping glc2ocn
  Add comments about not needing to add fields to x2o_fluxes and x2i_fluxes
  Point to new glc2ocn mapping files
  Allow different glc2ocn mappings for liq and ice
jgfouca added a commit that referenced this issue Mar 13, 2018
#1963)

Fixes:

* DOCN_MODE fix for xmlchange
* compare_namelist bug in rare code path
* Fix memleak in gptl
* Fix setting of build_threaded
* Fix unicode problems with expect

Feature list:
* Add job-id info for CaseStatus entry for job submit
* Allow different glc2ocn mappings for liq and ice

[BFB]

* jgfouca/branch-for-to-acme-12-06-2017-pr: (21 commits)
  Ignore buildlib python bytecode files
  This is no longer needed
  fix issue in scripts_regression_tests
  Add ability to customize CaseStatus success message for a phase.
  Fix bug in compare namelists
  add test for xmlquery DOCN_MODE
  Fix memory leak of newtimers in merge_thread_data
  in splitting comp vars make sure comp isnt subset of name
  Update ChangeLog
  nthrds > 1 should set build_threaded flag
  Update ChangeLog
  Update ChangeLog
  fix pylint issue
  fix gptl threaded build, batch change for cheyenne
  correct path for includes used in build
  Check for unicode in expect()
  update ACME to E3SM and changes related to Issue #1519 and PR #2062
  Do not use normalization when mapping glc2ocn
  Add comments about not needing to add fields to x2o_fluxes and x2i_fluxes
  Point to new glc2ocn mapping files
  ...
@rljacob rljacob closed this as completed Mar 14, 2018
@billsacks
Copy link
Member

This issue was closed on the cime call because we felt that the primary issue (in the original comment) doesn't need any more done with it at this point. However, as I look back at this, I see that there are some comments that may or may not have been resolved. For people who made these comments, I'd suggest opening a new issue if you feel there's something that still needs to be addressed. (@cacraigucar we did discuss #1519 (comment) and @mvertens says that is in progress.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants