MizuRoute lake grids #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y a simpler grid than the grid that doesn't include lakes as it manages them with a complex river structure
…ge the existing grids to match the desired grid alias convention
ccs_config_cesm0.0.38
ccs_config_cesm0.0.49
fischer-ncar
approved these changes
Dec 16, 2022
jedwards4b
approved these changes
Dec 16, 2022
|
I ran the test SMS_Ld1_D.f09_f09_rHDMAlk_mg17.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default and it PASSes. |
|
I just looked at the results of query_config --grids, and I realize that I didn't fix all of the mizuRoute grids. I thought I had fixed them, but these still need to be changed: hcru_hcru_mt13_rMERIT hcru_hcru_mt13_rHDMA f09_f09_mg17_rHDMA f09_f09_mg17_rMERIT f19_f19_mg17_rHDMA f19_f19_mg17_rMERIT |
|
Oh, the problem is that there are mizuRoute grids defined for MCT -- but I should just remove those. |
…uncitonal with NUOPC
|
OK I removed the mizuRoute grids from MCT, and did a namelist check for the new aliases, and they all work. So this is ready from my perspective. @fischer-ncar can you merge it now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some new grids for mizuRoute lake HDMA-lake option, and also changes the mizuRoute grid aliases to the convention discussed previously.
Fixes #67
Uses the convention as addressed in #70