-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rme/cesm pop 2 1 20240202 #82
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great, but I'm a little confused about why it works... I did the following:
$ git clone -b remove_manage_externals https://github.com/jedwards4b/POP2-CESM.git POP_rme
$ cd POP_rme/
$ git submodule update --init
$ cd externals/MARBL/
$ git log --decorate | head -n 1
commit 75827e20f40b29a30361aff4eae9801f1036a916 (HEAD, tag: marbl0.43.0)
So it clearly checked out marbl0.43.0
, which is the branch of MARBL we want POP to use, but the head of the default branch is 6b2a5e4 (marbl0.39.1
). The only reference to a commit I see in .gitmodules
is fxtag
, which presumably requires fleximod to parse... so how did git know what commit to checkout?
ugh, it looks like I actually tested the branch from #80 (had both tabs open); let me close that PR in favor of this one and try again. |
Okay, I removed the
From the last line, you can see it's still checking out the correct MARBL tag (and I'm still curious about how it knows) |
Description of changes:
This change removes the manage_externals utility and replaces it with git-fleximod. None of the extended features of git-fleximod are used here so one can just use git-submodule instead. This allows POP to be used as part of the upcoming cesm2_3_beta18 tag which removes the manage_externals utility in cesm and moves to git-fleximod.
Testing:
Test case/suite:
Test status: bit for bit
Fixes [POP2 Github issue #]
User interface (namelist or namelist defaults) changes?