Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two answer changing fixes (fire, DWT_SLASH) and fix for urban streams for Clm45 #802

Merged
merged 10 commits into from
Sep 6, 2019
Merged

Two answer changing fixes (fire, DWT_SLASH) and fix for urban streams for Clm45 #802

merged 10 commits into from
Sep 6, 2019

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Sep 4, 2019 •
edited
Loading

Description of changes

Fire bug fix and DWT_SLASH change and fix urban stream years for clm4_5.

Specific notes

Contributors other than yourself, if any: @lawrencepj1 @olyson

CTSM Issues Fixed (include github issue #): #175, #787, #780
fixes #175 urban stream years for clm4_5
fixes #787 DWT_SLASH field
fixes #780 Bug in CN Fire Li 2016 which used latitude in degrees rather than radians

Are answers expected to change (and if so in what way)? Yes
clm5_0 BGC simulations fire ignition changes due to difference in cosine(lat) with
latitude properly in radian's rather than in degrees
A few fields associated with DWT_SLASH change by a small amount due to the averaging
difference for a few cases

Any User Interface Changes (namelist or namelist defaults changes)? N

Testing performed, if any: regular
Running standard testing on cheyenne and izumi

@ekluzek
Changes from @olyson to fix ESCOMP#780
63b2c81
@ekluzek
Merge commit 'f2869fe202f71c4fd8c854fce47089630b4396c5' into clm50cos…
986cf49 
…latfirefix

This is a fix for ESCOMP#787 for DWT_SLASH
@ekluzek
Remove the commit to update the params file, which shouldn't be done …
7f67efc 
…on this branch
@ekluzek
Merge tag 'ctsm1.0.dev061' into clm50coslatfirefix
ee939a7 
New clm5 paramsfile that has the bad date of 631 changed to 701. Along with some simple bit for
bit changes. Removing some problematic options. Making Dynamic Vegetation a deprecated option
that requires you to use -ignore_warnings with it.
@ekluzek
Changes for ESCOMP#787 for dwt_slash_flux
b2cf3a6
@ekluzek
Make sure urbantv is set for clm4_5 ESCOMP#175
f293334
@ekluzek
Merge tag 'ctsm1.0.dev062' into clm50coslatfirefix
ae415da 
Move hobart tests to izumi
@ekluzek ekluzek added priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete tag: bug - impacts science labels Sep 4, 2019
@ekluzek ekluzek self-assigned this Sep 4, 2019
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 5, 2019

Strangely I'm getting two unexpected fails:

ERS_Ly3.f10_f10_musgs.I1850Clm50BgcCropCmip6.cheyenne_intel.clm-basic
SMS_Lm1_D.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_intel.clm-output_crop_highfreq

I'm rerunning them on ctsm1.0.dev062, to make sure it is indeed a new fail. I think the problem must be in the DWT_SLASH change.

@ekluzek ekluzek changed the title Three answer changing fixes (fire, DWT_SLASH, urban streams for clm4_5) Two answer changing fixes (fire, DWT_SLASH) and fix for urban streams for Clm45 Sep 6, 2019
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 6, 2019

The list of test that changes answers:

DAE_N2_D_Lh12.f10_f10_musgs.I2000Clm50BgcCropGs.cheyenne_intel.clm-DA_multidrv
ERI_D_Ld9.f10_f10_musgs.I1850Clm50Bgc.cheyenne_gnu.clm-default
ERI_D_Ld9.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_gnu.clm-default
ERI_D_Ld9.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
ERI_D_Ld9.ne30_g16.I2000Clm50BgcCruGs.cheyenne_intel.clm-vrtlay
ERI_Ld9.f10_f10_musgs.I1850Clm50Bgc.cheyenne_gnu.clm-drydepnomegan
ERI_Ld9.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_gnu.clm-default
ERI_Ld9.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
ERI_Ld9.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-drydepnomegan
ERI_N2_Ld9.f19_g17.I2000Clm50BgcCrop.cheyenne_intel.clm-default
ERP_D.f10_f10_musgs.IHistClm50Bgc.cheyenne_gnu.clm-decStart
ERP_D.f10_f10_musgs.IHistClm50Bgc.cheyenne_intel.clm-decStart
ERP_D_Ld10_P36x2.f10_f10_musgs.IHistClm50BgcCrop.cheyenne_intel.clm-ciso_decStart
ERP_D_Ld3_P36x2.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_gnu.clm-default
ERP_D_Ld3_P36x2.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
ERP_D_Ld5.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_gnu.clm-ciso_flexCN_FUN
ERP_D_Ld5.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-NoVSNoNI
ERP_D_Ld5.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-rootlit
ERP_D_Ld5.f10_f10_musgs.IHistClm50BgcCrop.cheyenne_intel.clm-allActive
ERP_D_Ld5.f19_g17.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
ERP_D_Ld5.f19_g17.I2000Clm50BgcCruGs.cheyenne_intel.clm-fire_emis
ERP_D_Ld5.f19_g17.IHistClm50Bgc.cheyenne_intel.clm-drydepnomegan
ERP_D_Ld5.f19_g17_gl4.I1850Clm50BgcCrop.cheyenne_intel.clm-glcMEC_changeFlags
ERP_D_Ld9.f19_g17.I2000Clm50Cn.cheyenne_intel.clm-drydepnomegan
ERP_D_P36x2_Ld3.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_gnu.clm-default
ERP_D_P36x2_Ld3.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_intel.clm-default
ERP_D_P36x2_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_gnu.clm-default
ERP_D_P36x2_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_gnu.clm-snowveg_norad
ERP_D_P36x2_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-cn_conly
ERP_D_P36x2_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
ERP_D_P36x2_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-flexCN_FUN
ERP_D_P36x2_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-luna
ERP_D_P36x2_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-noFUN_flexCN
ERP_D_P36x2_Ld30.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
ERP_D_P36x2_Ld5.f10_f10_musgs.I2000Clm50BgcCrop.cheyenne_intel.clm-irrig_spunup
ERP_D_P36x2_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.clm-irrig_spunup
ERP_Ld3.f09_g17.I1850Clm50BgcCropCru.cheyenne_intel.clm-ciso
ERP_Ld5.f10_f10_musgs.I1850Clm50Bgc.cheyenne_gnu.clm-default
ERP_Ld5.f10_f10_musgs.I1850Clm50Bgc.cheyenne_intel.clm-default
ERP_Ld5.f10_f10_musgs.I1850Clm50Bgc.cheyenne_intel.clm-drydepnomegan
ERP_Ld5.f19_g17.I1850Clm50Bgc.cheyenne_intel.clm-default
ERP_Ld5.f19_g17.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
ERP_Ly3_P72x2.f10_f10_musgs.IHistClm50BgcCrop.cheyenne_intel.clm-cropMonthOutput
ERP_P180x2_D_Ld5.f19_g17_gl4.I1850Clm50BgcCropG.cheyenne_intel.clm-glcMEC_increase
ERP_P36x2_D_Ld3.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_gnu.clm-extra_outputs
ERP_P36x2_D_Ld5.f10_f10_musgs.I1850Clm50Bgc.cheyenne_intel.clm-ciso
ERP_P36x2_D_Ld5.f10_f10_musgs.I2000Clm50Cn.cheyenne_gnu.clm-default
ERP_P36x2_D_Ld5.f10_f10_musgs.I2000Clm50Cn.cheyenne_intel.clm-default
ERP_P36x2_D_Ld5.f10_f10_musgs.I2000Ctsm50NwpBgcCropGswpGs.cheyenne_intel.clm-default
ERP_P36x2_D_Ld5.f10_f10_musgs.IHistClm45BgcCruGs.cheyenne_intel.clm-decStart
ERP_P36x2_Lm13.f10_f10_musgs.IHistClm50Bgc.cheyenne_gnu.clm-monthly
ERP_P36x2_Lm13.f10_f10_musgs.IHistClm50Bgc.cheyenne_intel.clm-monthly
ERP_P72x2_Lm25.f10_f10_musgs.I2000Clm50BgcCrop.cheyenne_intel.clm-monthly
ERP_P72x2_Lm36.f10_f10_musgs.I2000Clm50BgcCrop.cheyenne_intel.clm-clm50cropIrrigMonth_interp
ERP_P72x2_Lm7.f10_f10_musgs.I2000Clm50BgcCrop.cheyenne_intel.clm-irrig_alternate_monthly
ERP_P72x2_Ly3.f10_f10_musgs.I2000Clm50BgcCrop.cheyenne_intel.clm-irrig_o3_reduceOutput
ERS_D.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_intel.clm-reseedresetsnow
ERS_D_Ld12.f10_f10_musgs.I1850Clm50BgcCropG.cheyenne_intel.clm-glcMEC_spunup_inc_dec_bgc
ERS_D_Ld3.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_gnu.clm-default
ERS_D_Ld3.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_intel.clm-default
ERS_D_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_gnu.clm-default
ERS_D_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-deepsoil_bedrock
ERS_D_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
ERS_D_Ld3.f19_g17_gl4.I1850Clm50BgcCrop.cheyenne_intel.clm-clm50dynroots
ERS_D_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOnFloodOnEffvelOn
ERS_D_Ld5.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
ERS_D_Ld5.f10_f10_musgs.IHistClm50BgcQianGs.cheyenne_intel.clm-ciso_bombspike1963DecStart
ERS_Ld3.f09_g17.I1850Clm50BgcCrop.cheyenne_intel.clm-rad_hrly_light_res_half
ERS_Lm40_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianGs.cheyenne_gnu.clm-monthly
ERS_Lm54_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianGs.cheyenne_intel.clm-cropMonthOutput
ERS_Ly20_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianGs.cheyenne_intel.clm-cropMonthOutput
ERS_Ly3_Mmpi-serial.1x1_smallvilleIA.IHistClm50BgcCropQianGs.cheyenne_gnu.clm-cropMonthOutput
ERS_Ly3_P72x2.f10_f10_musgs.IHistClm50BgcCropG.cheyenne_intel.clm-cropMonthOutput
ERS_Ly5_P144x1.f10_f10_musgs.IHistClm50BgcCrop.cheyenne_intel.clm-cropMonthOutput
ERS_Ly5_P72x1.f10_f10_musgs.IHistClm45BgcCrop.cheyenne_intel.clm-cropMonthOutput
ERS_Ly6_Mmpi-serial.1x1_smallvilleIA.IHistClm50BgcCropQianGs.cheyenne_intel.clm-cropMonthOutput
LCISO_Lm13.f10_f10_musgs.IHistClm50BgcCrop.cheyenne_intel.clm-ciso_monthly
LII2FINIDATAREAS_D_P360x2_Ld1.f09_g17.I1850Clm50BgcCrop.cheyenne_intel.clm-default
LII_D_Ld3.f19_g17_gl4.I2000Clm50BgcCrop.cheyenne_intel.clm-glcMEC_spunup_1way
LVG_Ld5_D.f10_f10_musgs.I1850Clm50Bgc.cheyenne_intel.clm-no_vector_output
LWISO_Ld10.f10_f10_musgs.I2000Clm50BgcCropGs.cheyenne_gnu.clm-coldStart
PEM_D_Ld5.ne30_g16.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
PET_P36x2_D.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_gnu.clm-default
PET_P36x2_D.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_intel.clm-default
SMS.f19_g17.I2000Clm50Cn.cheyenne_intel.clm-default
SMS_D_Ld1.f09_g17.I1850Clm50BgcSpinup.cheyenne_intel.clm-cplhist
SMS_D_Ld3.f10_f10_musgs.I1850Clm50BgcCrop.cheyenne_intel.clm-default
SMS_D_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_gnu.clm-default
SMS_D_Ld3.f10_f10_musgs.I2000Clm50BgcCruGs.cheyenne_intel.clm-default
SMS_Ld1.f09_g17.I1850Clm50Bgc.cheyenne_intel.clm-drydepnomegan
SMS_Ld1.f09_g17.I2000Clm50BgcCruGs.cheyenne_intel.clm-af_bias_v7
SMS_Ld2_D.f09_g17.I1850Clm50BgcCropCmip6.cheyenne_intel.clm-basic_interp
SMS_Ld5.f19_g17.IHistClm50Bgc.cheyenne_intel.clm-decStart
SMS_Lm1.f10_f10_musgs.I1850Clm50BgcCropCmip6waccm.cheyenne_gnu.clm-basic
SMS_Lm1.f19_g17_gl4.I1850Clm50Bgc.cheyenne_intel.clm-clm50dynroots
SMS_Lm13.f19_g17.I2000Clm50BgcCrop.cheyenne_intel.clm-cropMonthOutput
SMS_Lm1_D.f10_f10_musgs.I2000Clm50BgcCrop.cheyenne_intel.clm-snowlayers_3_monthly
SMS_Ly3_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianGs.cheyenne_intel.clm-clm50dynroots
SOILSTRUCTUD_Ld5.f10_f10_musgs.I2000Clm50BgcCropGs.cheyenne_intel.clm-default
SSP_D_Ld10.f19_g17.I1850Clm50Bgc.cheyenne_intel.clm-rtmColdSSP
SSP_D_Ld4.f09_g17.I1850Clm50BgcCrop.cheyenne_intel.clm-ciso_rtmColdSSP
SSP_Ld10.f19_g17.I1850Clm50Bgc.cheyenne_intel.clm-rtmColdSSP

ERI_D_Ld9_P48x1.f10_f10_musgs.I2000Clm50BgcCruGs.izumi_nag.clm-reduceOutput
ERP_D_Ld5_P48x1.f10_f10_musgs.I1850Clm50Bgc.izumi_nag.clm-ciso
ERP_D_Ld5_P48x1.f10_f10_musgs.I2000Clm50BgcCruGs.izumi_nag.clm-reduceOutput
ERP_D_P48x1.f10_f10_musgs.IHistClm50Bgc.izumi_nag.clm-decStart
ERP_Ld5_P48x1.f10_f10_musgs.I1850Clm50Bgc.izumi_nag.clm-ciso
ERP_Ld5_P48x1.f10_f10_musgs.I1850Clm50Bgc.izumi_nag.clm-default
ERP_Ld5_P48x1.f10_f10_musgs.I2000Clm50BgcCruGs.izumi_nag.clm-flexCN_FUN
ERP_Ld5_P48x1.f10_f10_musgs.I2000Clm50BgcCruGs.izumi_nag.clm-luna
ERP_Ld5_P48x1.f10_f10_musgs.I2000Clm50BgcCruGs.izumi_nag.clm-noFUN_flexCN
ERP_Ld5_P48x1.f10_f10_musgs.I2000Clm50BgcCruGs.izumi_nag.clm-reduceOutput
ERS_Ly5_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianGs.izumi_nag.clm-monthly
SMS.f10_f10_musgs.I2000Clm50BgcCrop.izumi_gnu.clm-crop
SMS.f10_f10_musgs.I2000Clm50BgcCrop.izumi_intel.clm-crop
SMS.f10_f10_musgs.I2000Clm50BgcCrop.izumi_pgi.clm-crop
SMS_D.f10_f10_musgs.I2000Clm50BgcCrop.izumi_gnu.clm-crop
SMS_D.f10_f10_musgs.I2000Clm50BgcCrop.izumi_intel.clm-crop
SMS_D.f10_f10_musgs.I2000Clm50BgcCrop.izumi_pgi.clm-crop
SMS_D_Ld10.f10_f10_musgs.I2000Clm50BgcCropGs.izumi_intel.clm-tracer_consistency
SMS_D_Ld1_P48x1.f10_f10_musgs.I2000Clm50BgcCruGs.izumi_nag.clm-af_bias_v7
SMS_D_Ld5.f10_f10_musgs.I2000Clm50BgcCrop.izumi_nag.clm-irrig_alternate
SMS_D_P48x1_Ld5.f10_f10_musgs.I2000Clm50BgcCrop.izumi_nag.clm-irrig_spunup
SMS_Ld5_D_P48x1.f10_f10_musgs.IHistClm50Bgc.izumi_nag.clm-decStart
SMS_Ld5_D_P48x1.f10_f10_musgs.IHistClm50Bgc.izumi_nag.clm-monthly
SMS_P48x1_D_Ld5.f10_f10_musgs.I2000Clm50Cn.izumi_nag.clm-default

@ekluzek ekluzek merged commit 14cb3dd into ESCOMP:master Sep 6, 2019
@ekluzek ekluzek deleted the clm50coslatfirefix branch September 6, 2019 03:28
@samsrabin samsrabin added bug something is working incorrectly science Enhancement to or bug impacting science labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ekluzek ekluzek

Labels
bug something is working incorrectly PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science
Projects
None yet
Milestone
No milestone
2 participants
@ekluzek @samsrabin