-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move fix for transient non-crop to release-clm5.0 branch #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix associated with issue ESCOMP#538. Minor code mods that allow %cft to advance beyond 1850 in transient pft simulations.
Changing the default logic in CLMBuildNamelist.pm instead of hardwiring do_transient_crops to always equal do_transient_pfts in the code. This fix as is may be incomplete. It allows do_transient_crops = .true. when use_crop = .false. but it does not make sure do_transient_crops = do _transient_pfts.
…_transient consistency, grainproduct, and create_crop_landunit
ekluzek
added
severity: critical
priority: high
High priority to fix/merge soon, e.g., because it is a problem in important configurations
PR status: ready
PR: this is ready to merge in, with all tests satisfactory and reviews complete
labels
Oct 29, 2018
Testing as expected:
|
mariuslam
pushed a commit
to NordicESMhub/ctsm
that referenced
this pull request
Aug 26, 2019
…nfsc-fix litter_moisture initialization fix
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jun 27, 2024
Move fix for transient non-crop to release-clm5.0 branch
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jul 5, 2024
Move fix for transient non-crop to release-clm5.0 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR status: ready
PR: this is ready to merge in, with all tests satisfactory and reviews complete
priority: high
High priority to fix/merge soon, e.g., because it is a problem in important configurations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Move changes from ctsm1.0.dev013 to release-clm5.0 branch. This is the fix for transient non-crop simulations.
Specific notes
Contributors other than yourself, if any: none
CTSM Issues Fixed (include github issue #): #538
Are answers expected to change (and if so in what way)? Yes (for non-crop clm45/clm50 transient cases)
Currently generic crop areas stay at 1850 levels. This fix allows them to change as they should.
Any User Interface Changes (namelist or namelist defaults changes)? Just for mksurfdata.pl
Testing performed, if any: None now (but was done on master) will be repeated before accepted.
NOTE: Be sure to check your Coding style against the standard:
https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines