Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "What's New in CTSM 5.3" #2789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Sep 25, 2024

Description of changes

  • Rearranging a bit to highlight things that users probably care about more than software engineers.
  • Removing line breaks, as this harms searchability.
  • Using hash marks as Markdown headers instead of title underlines, as these are easier to understand.

It might be easier for further discussion to take place in a Google Doc for now... I've made one here.

Specific notes

Contributors other than yourself, if any: @ekluzek

CTSM Issues Fixed: None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: None needed.

Remaining questions/tasks

  • Add links to PRs/issue throughout, so that users can get more information.
  • Move to docs directory?

@samsrabin samsrabin added documentation additions or edits to user-facing documentation bfb bit-for-bit labels Sep 25, 2024
- Snow thermal conductivity is now Sturm_1997
- New IC file for f09 1850
- Snow thermal conductivity method is now `Sturm_1997`
- New initial conditions file for f09 ("1-degree") 1850, with more in progress
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“with more in progress”—yes?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct.

- Surface datasets now provided for the `ne0np4.POLARCAP.ne30x4` grid.
- Surface datasets now have their version number embedded to prevent mismatch of surface dataset and CTSM version.
- Remove the `--hires_pft` option from `mksurfdata_esmf` as we don't have the datasets for it.
- Remove `VIC` fields from surface datasets.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are (were) VIC fields?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VIC is an alternative hydrological parameterization that you could turn on, that we are deprecating. It required a few fields on the surface datasets to be used. This added complexity to both surface datasets as well as testing for it. So removing it simplifies a bunch of things all around.

We could look for what fields were added to the surface datasets, but I think just saying they ware removed is sufficient here.

- Updates to BGC fire method

Changes for all physics versions:

- Parameter files updated
- FATES parameter file updated
- Glacier region 1 is now undefined
Copy link
Collaborator Author

@samsrabin samsrabin Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Glacier region 1 is now undefined": What does this mean in terms of answer changes? Why should users care?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I need to look at more carefully to describe accurately. We also might want to get Bill to help make sure we are accurate.


- With new surface datasets the following GLC fields have region "1" set to UNSET:
glacier_region_behavior, glacier_region_melt_behavior, glacier_region_ice_runoff_behavior
- With new surface datasets the following GLC fields have region "1" set to UNSET: glacier_region_behavior, glacier_region_melt_behavior, glacier_region_ice_runoff_behavior
Copy link
Collaborator Author

@samsrabin samsrabin Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"With new surface datasets the following GLC fields...": What does this mean in terms of answer changes? Why should users care?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

This is a good way to frame it by the way "why should users care"?. That's a good way to handle everything here.

- Fix an important bug on soil fields that was there since `ctsm5.2.0`. This has the side effect of `mksurfdata_esmf` now giving identical answers with a change in number of processors, as it should.
- Surface datasets now provided for the `ne0np4.POLARCAP.ne30x4` grid.
- Surface datasets now have their version number embedded to prevent mismatch of surface dataset and CTSM version.
- Remove the `--hires_pft` option from `mksurfdata_esmf` as we don't have the datasets for it.
Copy link
Collaborator Author

@samsrabin samsrabin Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is --hires_pft removal maybe not worth mentioning? If the datasets aren't available, was anyone using it? Moreover, this tool change doesn’t fit with the substantive changes to surface datasets described in the rest of the section.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I thought it worth mentioning for users of mksurfdata_esmf because it was a user visible option that we took away. Hence, it's good to explain why. The point is it was an option that wasn't functional so we removed it, and we'll return it when it is functional.

- Pass active glacier (CISM) runoff directly to river model (MOSART)
- Add the option for using matrix for Carbon/Nitrogen BGC spinup
- Add the option for using Matrix CN method for Carbon/Nitrogen BGC spinup
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CN Matrix is an option, does it really fit in the “answer changes” section?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, it only changes answers when turned on, which normally is just for spinup.


- With new surface datasets the following GLC fields have region "1" set to UNSET:
glacier_region_behavior, glacier_region_melt_behavior, glacier_region_ice_runoff_behavior
- With new surface datasets the following GLC fields have region "1" set to UNSET: glacier_region_behavior, glacier_region_melt_behavior, glacier_region_ice_runoff_behavior
- Updates to allow creating transient landuse timeseries files going back to 1700.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So mksurfdata_esmf can now make land-use timeseries files back to 1700. Have any of those actually been made?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did make 1700 for f09. I'm pretty sure we have them in the namelist defaults. Although I'd have to check.


New surface datasets:
=====================
## New surface datasets
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section title also mention land-use timeseries files?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think of "surface datasets" describing both, but for clarity you could spell out both fsurdat and flanduse_timeseries files.


Changes to CTSM Answers:
========================
## Changes to CTSM answers
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should mention new surface datasets and land-use timeseries files. Are those only used in clm6_0 physics or all physics versions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All physics versions.

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Love the cleanup here.


New surface datasets:
=====================
## New surface datasets
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think of "surface datasets" describing both, but for clarity you could spell out both fsurdat and flanduse_timeseries files.

- Updates to BGC fire method

Changes for all physics versions:

- Parameter files updated
- FATES parameter file updated
- Glacier region 1 is now undefined
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I need to look at more carefully to describe accurately. We also might want to get Bill to help make sure we are accurate.


- With new surface datasets the following GLC fields have region "1" set to UNSET:
glacier_region_behavior, glacier_region_melt_behavior, glacier_region_ice_runoff_behavior
- With new surface datasets the following GLC fields have region "1" set to UNSET: glacier_region_behavior, glacier_region_melt_behavior, glacier_region_ice_runoff_behavior
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

This is a good way to frame it by the way "why should users care"?. That's a good way to handle everything here.


- With new surface datasets the following GLC fields have region "1" set to UNSET:
glacier_region_behavior, glacier_region_melt_behavior, glacier_region_ice_runoff_behavior
- With new surface datasets the following GLC fields have region "1" set to UNSET: glacier_region_behavior, glacier_region_melt_behavior, glacier_region_ice_runoff_behavior
- Updates to allow creating transient landuse timeseries files going back to 1700.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did make 1700 for f09. I'm pretty sure we have them in the namelist defaults. Although I'd have to check.

- Fix an important bug on soil fields that was there since `ctsm5.2.0`. This has the side effect of `mksurfdata_esmf` now giving identical answers with a change in number of processors, as it should.
- Surface datasets now provided for the `ne0np4.POLARCAP.ne30x4` grid.
- Surface datasets now have their version number embedded to prevent mismatch of surface dataset and CTSM version.
- Remove the `--hires_pft` option from `mksurfdata_esmf` as we don't have the datasets for it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I thought it worth mentioning for users of mksurfdata_esmf because it was a user visible option that we took away. Hence, it's good to explain why. The point is it was an option that wasn't functional so we removed it, and we'll return it when it is functional.

- Surface datasets now provided for the `ne0np4.POLARCAP.ne30x4` grid.
- Surface datasets now have their version number embedded to prevent mismatch of surface dataset and CTSM version.
- Remove the `--hires_pft` option from `mksurfdata_esmf` as we don't have the datasets for it.
- Remove `VIC` fields from surface datasets.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VIC is an alternative hydrological parameterization that you could turn on, that we are deprecating. It required a few fields on the surface datasets to be used. This added complexity to both surface datasets as well as testing for it. So removing it simplifies a bunch of things all around.

We could look for what fields were added to the surface datasets, but I think just saying they ware removed is sufficient here.

@ekluzek
Copy link
Collaborator

ekluzek commented Oct 23, 2024

@samsrabin it would be nice to bring this in, should maybe you and I meet to go over it?

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit documentation additions or edits to user-facing documentation next this should get some attention in the next week or two. Normally each Thursday SE meeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants