Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "polarcap" grid for cesm3 release #2716

Merged
merged 8 commits into from
Oct 30, 2024

Conversation

adamrher
Copy link
Contributor

@adamrher adamrher commented Aug 20, 2024

Description of changes

CTSM PR for installing the POLARCAP grid in CESM.

Specific notes

All I did is replicate all the entries for ARCTICGRIS in namelist_defaults_ctsm.xml, which has year 1850, 2000, 1979-2026 support. It also has support for 6 combinations of atm/lnd physics (clm50, clm51, clm60) x (CAM6; CAM7). @ekluzek @samsrabin as the POLARCAP grid is new to CESM, I don't know that we need to support these older versions of atm/lnd physics, but I'm not necessarily opposed to them either. I'm flexible and will just defer to yall.

Surface datasets were generated with tag ctsm5.2.005.

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #):
Fixes #2386

Are answers expected to change (and if so in what way)? Not unless you're running this new grid.

Any User Interface Changes (namelist or namelist defaults changes)? Entires added to namelist defaults.

Does this create a need to change or add documentation? Did you do so? No and no.

Testing performed, if any:
Successfully completed a 1 day test using create_newcase set to grid ne0POLARCAPne30x4_ne0POLARCAPne30x4_mt12 and compset I2000Clm50Sp. No other tests performed.

@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Aug 21, 2024
@wwieder
Copy link
Contributor

wwieder commented Aug 21, 2024

Thanks @adamrher. We're in the process of testing and generating new surface datasets again for an upcoming CTSM5.3 tag that will be the final science tag for CESM3 development. Do you need these polar grids for work now, or can we wait to bring them in with the 5.3 series?

Also, I wonder if the tools used to generate this grid should be incorporated into the mksurfdata_esmf workflow?

@ekluzek ekluzek added the enhancement new capability or improved behavior of existing capability label Aug 22, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Aug 22, 2024

By the grids document we should support: 1979,1850,2000,1979-2026 surface datasets. But, we should separate the mksurfdata_esmf part of this from this part for CTSM support.

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 22, 2024

Things to do here:

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 22, 2024

@adamrher I'm thinking we should just support this for clm6_0 with cam7.0. With support for cam6.0 being next in priority. This would mainly be for IC file support, and users can still use other options, they'll just need to figure out what IC file to use.

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a list of things to do with this PR to come in. I'm marking it as approved as this looks done to me in terms of what @adamrher needs to give us.

@adamrher
Copy link
Contributor Author

By the grids document we should support: 1979,1850,2000,1979-2026 surface datasets.

@ekluzek in hindsight, I don't think we need 1850 support for the VR grids. And I noticed in namelist_defaults_ctsm.xml, that the fsurdat entries for 1850 are set to the 1979 fsurdat file for the ARCTIC,ARCTICGRIS VR grids, e.g.,

<fsurdat hgrid="ne0np4.ARCTIC.ne30x4"     sim_year="1850">
lnd/clm2/surfdata_esmf/ctsm5.2.0/surfdata_ne0np4.ARCTIC.ne30x4_hist_1979_78pfts_c240425.nc</fsurdat>

Which I replicated with the POLARCAP grid in this PR. Should we just modify these entries to sim_year="1979" so they are consistent with the file pointed to?

@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Aug 22, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Aug 22, 2024

@adamrher thanks for letting us know about not needing 1850. I removed it for the other VR grids in the grids spreadsheet. #2498 gets into supporting these 1979 datasets in a clearer more sustainable way. So we'll leave it like it is here for now.

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 20, 2024

@adamrher we have new surface dataset files for this grid as part of ctsm5.3.0 here:

/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/surfdata_esmf/ctsm5.3.0/surfdata_ne0np4.POLARCAP.ne30x4_hist_1979_78pfts_c240908.nc
/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/surfdata_esmf/ctsm5.3.0/landuse.timeseries_ne0np4.POLARCAP.ne30x4_SSP2-4.5_1979-2026_78pfts_c240908.nc

We haven't tested them though, and won't until I get back to this PR after ctsm5.3.0 is done. I have some important cesm3_0_beta03 work that will need to be before this for next week. But, if you'd like to try it yourself before I get to it, we could talk about how you could do that after ctsm5.3.0 is finished. Let me know next week if you'd like to do that...

@slevis-lmwg slevis-lmwg self-assigned this Oct 21, 2024
@slevis-lmwg slevis-lmwg changed the base branch from master to cesm3_0_beta04_changes October 25, 2024 22:45
@slevis-lmwg
Copy link
Contributor

@adamrher would you be ok giving me permission to push to this PR? You would have to:

  • Click Settings
  • Click Collaborators
  • Click Add people

If not, I would open a new PR to finish this work. Let me know your preference. Thanks, Adam.

@slevis-lmwg
Copy link
Contributor

@ekluzek are we still removing clm50 support here? I see a comment that I introduced very recently in our testlist:
Clm50 because that is what CAM tests currently; remove when CAM tests for Clm60

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Oct 29, 2024

Testing on derecho:
PASS ./build-namelist_test
PASS python testing
PEND aux_clm and ctsm_sci after corrections that I'm about to push

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Oct 30, 2024

derecho testing complete:
OK aux_clm
OK ctsm_sci

izumi:
OK aux_clm: roundoff diffs from the baseline due to this week's node upgrades; also a few tests decided that cesm.exe does not exist though it does; this may or may not have something to do with the upgrade; removing cesm.exe and rebuilding in one of the tests did not help.

@slevis-lmwg slevis-lmwg merged commit 4d8f308 into ESCOMP:cesm3_0_beta04_changes Oct 30, 2024
2 checks passed
@slevis-lmwg slevis-lmwg deleted the ctsm.polarcap branch October 30, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Install dual polar VR grid into CTSM
5 participants