Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LILAC references to mct #2374

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

billsacks
Copy link
Member

@billsacks billsacks commented Feb 16, 2024

Description of changes

Remove remaining references to mct. These appeared in two places:

  • LILAC
  • Unit tests

Specific notes

Contributors other than yourself, if any: @jedwards4b identified these

CTSM Issues Fixed (include github issue #):
Does one checkbox in #2294

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any:
Note: I ran the following testing with these changes off of ctsm5.1.dev167, then rebased the changes to the b4b-dev branch for the sake of this PR:

  • LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.clm-lilac: passes and bit-for-bit with ctsm5.1.dev167 (there were NLCOMP failures, but this looks like an issue with the baselines, since these changes shouldn't have impacted namelists at all)
  • Fortran unit tests on my Mac (they currently aren't working on derecho so I couldn't run them there)

It looks like the need for MCT was removed in
b4d64ac, when Mariana changed the
stream code to use CDEPS, but the initialization of MCT wasn't removed
at that time... but it looks like MCT is now unneeded, so going ahead
and removing it now.
Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billsacks Thank you!

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability code health improving internal code structure to make easier to maintain (sustainability) tag: simple bfb labels Feb 16, 2024
@ekluzek ekluzek self-assigned this Feb 22, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Feb 23, 2024

@billsacks I'm going to bring this in after #2385 so that it will bring in the fix for unit testing on Derecho. Then we'll be able to see the unit tests passing on Derecho.

@ekluzek ekluzek changed the title Remove references to mct Remove LILAC references to mct Mar 18, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Mar 18, 2024

Unit-testing now PASSes on Derecho with updated branch.

This also just resolves one checkbox in #2294. But, I'll bring it in as it is...

@ekluzek
Copy link
Collaborator

ekluzek commented Mar 19, 2024

Testing ran as expected, so merging.

@ekluzek ekluzek merged commit 9d70347 into ESCOMP:b4b-dev Mar 19, 2024
2 checks passed
@ekluzek ekluzek deleted the lilac_remove_mct branch March 19, 2024 18:31
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability
Projects
Status: Done (non release/external)
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants