-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run_sys_tests: Check Python environment for FatesColdTwoStream tests #2326
Merged
slevis-lmwg
merged 11 commits into
ESCOMP:master
from
samsrabin:check-pyenv-FatesColdTwoStream
Jan 25, 2024
Merged
run_sys_tests: Check Python environment for FatesColdTwoStream tests #2326
slevis-lmwg
merged 11 commits into
ESCOMP:master
from
samsrabin:check-pyenv-FatesColdTwoStream
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsrabin
added
the
PR status: awaiting review
Work on this PR is paused while waiting for review.
label
Jan 19, 2024
samsrabin
commented
Jan 22, 2024
@ekluzek Done! |
samsrabin
added
PR status: ready
PR: this is ready to merge in, with all tests satisfactory and reviews complete
and removed
PR status: awaiting review
Work on this PR is paused while waiting for review.
labels
Jan 22, 2024
Merged
samsrabin
added a commit
to samsrabin/CTSM
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bfb
bit-for-bit
PR status: ready
PR: this is ready to merge in, with all tests satisfactory and reviews complete
testing
additions or changes to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
FatesColdTwoStream
andFatesColdTwoStreamNoCompFixedBioGeo
tests use the$FATESDIR/tools/modify_fates_paramfile.py
script, which requires certain non-standard Python packages. Now,run_sys_tests
will check for the availability of those packages.Specific notes
Uses existing
_try_systemtests()
function (now generalized and renamed_check_py_env()
).Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #): n/a
Are answers expected to change (and if so in what way)? No.
Any User Interface Changes (namelist or namelist defaults changes)? No.
Testing performed, if any:
Unloaded all modules on Izumi and tried to submit
run_sys_tests
using-s
,-f
, and-t
arguments that requested those tests. It successfully errors, saying:It also works on Derecho.
black
andpylint
pass.