Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fates history tests to use double precision #2010

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

glemieux
Copy link
Collaborator

Description of changes

The current fates regression tests default to single precision. This PR updates to double precision

The PR resolves #1986

Specific notes

Contributors other than yourself, if any:
@ekluzek

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?
Yes

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on cheyenne for intel/gnu and izumi for intel/gnu/nag/pgi is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

@glemieux
Copy link
Collaborator Author

glemieux commented May 25, 2023

Regression testing the fates suite against baseline fates-sci.1.65.6_api.25.4.0-ctsm5.1.dev127 is showing diffs for all fates test modules as expected. Simple history outputs, like FATES_NCOHORTS and FATES_TVEG24, are showing round off errors of 10E-16.

I'll run this through the aux_clm tests shortly.

@glemieux
Copy link
Collaborator Author

Regression testing the aux_clm test suite on cheyenne and izumi are b4b with the exception of the expected DIFFs in all fates test mods.

@glemieux glemieux requested a review from ekluzek May 27, 2023 00:16
@ekluzek ekluzek merged commit 5df6c98 into ESCOMP:master Jun 1, 2023
@ekluzek ekluzek deleted the fates-history-doubleprec branch June 1, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change output from FATES tests to be double precision
2 participants