Add option to convert wetlands to land; apply it by default for CLM51 physics #1890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds a new namelist option, "convert_ocean_to_land", which converts all wetland area to natural veg (typically bare ground) at runtime. This is set to true by default when using CLM51 physics.
In addition, this PR makes a minor change to the setting of soil properties in mksurfdata: Previously, soil properties were set to some default value outside of the pctlnd_pft-determined land mask. But I can't see any reason why that needs to be done, and doing so could remove some valid soil properties in the situation where there is a grid cell that has valid soil properties even though the pctpft dataset claims the area is ocean.
Note that this PR is into the ctsm5.2.mksurfdata branch. Most of the changes could be applied directly to master, but there are some related changes to mksurfdata that motivated me to make this PR into the ctsm5.2.mksurfdata branch. However, standard f09 surface datasets don't show any changes due to the code changes in mksurfdata here, and the mksurfdata changes aren't critical anyway, so it would be reasonable to rebase the non-mksurfdata changes onto master if we want them available sooner.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? Yes: changes answers for CLM51 cases in a few grid cells that used to be wetland but now are classified as bare ground.
Any User Interface Changes (namelist or namelist defaults changes)? Adds new namelist variable, "convert_ocean_to_land"
Testing performed, if any:
ERP_D_P36x2_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.cheyenne_intel.clm-default
: passes and bit-for-bitERP_Ld9.f45_g37.I2000Clm51Bgc.cheyenne_intel.clm-default
: passes but changes answers, as expectedERI_D_Ld9.f10_f10_mg37.I1850Clm51Bgc.cheyenne_gnu.clm-default
: passes (didn't do baseline comparisons, but expect baseline comparisons to fail)@slevisconsulting and @ekluzek - I am assigning both of you as reviewers, but probably this only needs a review from one of you. I would especially welcome a review of my changes to mksurfdata, in case you see any reason why my change to the mapping of soil properties might be problematic. As mentioned above, this doesn't lead to any differences in an f09 1850 surface dataset, but these changes could in principle lead to differences in some surface datasets (probably those at higher resolutions).