CLM is getting the mask from the clm namelist_defaults rather than from top level scripts

[ekluzek]

Erik Kluzek < erik > - 2017-06-06 15:56:42 -0600
Bugzilla Id: 2470
Bugzilla CC: andre, dlawren, mvertens, rfisher, sacks,

This is certainly in clm4_5_16_r243 and goes quite a way back. Quite a while ago CLM had to assume the land ocean mask based on the specific grid. The high level CESM scripts have evolved so that now the env variable MASK_GRID is set which can be used to set the mask for all of the standard global grids. The only thing that CLM uses with the mask is to find the appropriate initial conditions file. Since, we are interpolating for CLM45 and CLM50 the assumed mask doesn't matter. But, it does matter for CLM40, and when we tried to go from testing g16 masks to g17 CLM thought the mask was g16 and so found g16 finidat files, but they are incompatible when running at a g17 mask.

So to fix this we need to make sure components/clm/cime_config/buildnml sends MASK_GRID to clm build-namelist with the -mask option (for standard global grids). When the MASK_GRID is null it should use the assumed mask (which should only be for single point or regional cases).

[ekluzek]

This issue came up again with updating initial condition files that used the gx1v6 mask, while some tests were using the gx1v7 mask because it didn't realize they were different. So to correct it I'm putting in this change...

diff --git a/cime_config/buildnml b/cime_config/buildnml
index dc11d27..73855da 100755
--- a/cime_config/buildnml
+++ b/cime_config/buildnml
@@ -60,6 +60,7 @@ def buildnml(case, caseroot, compname):
     run_refdate = case.get_value("RUN_REFDATE")
     run_reftod = case.get_value("RUN_REFTOD")
     glc_nec = case.get_value("GLC_NEC")
+    mask = case.get_value("MASK_GRID")
 
     # -----------------------------------------------------
     # Clear out old data
@@ -166,6 +167,11 @@ def buildnml(case, caseroot, compname):
     else:
         usecase = ""
 
+    if ( (mask != "null") and (mask != "UNSET") ):
+       gridmask = "-mask %s" %mask
+    else:
+       gridmask = ""
+
     start_ymd = run_startdate.replace('-','')
 
     if ('-01-01' in run_startdate) or ('-09-01' in run_startdate):
@@ -230,11 +236,11 @@ def buildnml(case, caseroot, compname):
         command = ("%s -cimeroot %s -infile %s -csmdata %s -inputdata %s %s -namelist \"&clm_inparm  start_ymd=%s %s/ \" "
                    "%s %s -res %s %s -clm_start_type %s -envxml_dir %s -l_ncpl %s "
                    "-lnd_frac %s -glc_nec %s -co2_ppmv %s -co2_type %s -config %s "
-                   "%s %s %s"
+                   "%s %s %s %s"
                    %(cmd, _CIMEROOT, infile, din_loc_root, inputdata_file, ignore, start_ymd, clm_namelist_opts, 
                      nomeg, usecase, lnd_grid, clmusr, start_type, caseroot, lnd_ncpl, 
                      lndfrac_file, glc_nec, ccsm_co2_ppmv, clm_co2_type, config_cache_file, 
-                     clm_bldnml_opts, spinup, tuning))
+                     clm_bldnml_opts, spinup, tuning, gridmask))
 
         rc, out, err = run_cmd(command, from_dir=clmconf)
         expect(rc==0,"Command %s failed rc=%d\nout=%s\nerr=%s"%(cmd,rc,out,err))

[ekluzek]

Also need to add the gx1v7 mask to the namelist_definition files.