Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some dead code #1333

Closed
billsacks opened this issue Apr 12, 2021 · 0 comments
Closed

Remove some dead code #1333

billsacks opened this issue Apr 12, 2021 · 0 comments
Assignees
@billsacks
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)

Comments

@billsacks
Copy link
Member

We should remove this dead code:

CTSM/src/cpl/utils/lnd_import_export_utils.F90

Lines 87 to 94 in 30ca184

! modify specific humidity if precip occurs
if (1==2) then
if ((forc_rainc(g) + forc_rainl(g)) > 0._r8) then
forc_q = 0.95_r8 * qsat_kg_kg
!forc_q = qsat_kg_kg
wateratm2lndbulk_inst%forc_q_not_downscaled_grc(g) = forc_q
endif
endif

@swensosc says:

I also noticed something that may have come in from one of my code changes a long while ago [referencing the above code]:

  1. this was some code that I think was from when we were looking at why the humidity was so low during days with rain, and I think we decided it was due to the older cruncep forcing having some inconsistencies. But it was really just to see what would happen to things like transpiration if humidity was higher. 2) it is never triggered due to the if-block.
    So maybe that could be removed at some point.
@billsacks billsacks added code health improving internal code structure to make easier to maintain (sustainability) tag: simple bfb labels Apr 12, 2021
@billsacks billsacks self-assigned this Apr 12, 2021
billsacks added a commit that referenced this issue Apr 20, 2021
@billsacks
Merge branch 'antarctica_defaults'
075b273 
Misc bfb enhancements and fixes

(1) If CISM is running over Antarctica, use virtual glacier columns over
    Antarctica

(2) Remove "mec" from some glacier/ice variable names (it is misleading
    to have "mec" in variable names when the ice landunit can actually
    have multiple columns *or* a single column) (#1294)

(3) Add history file metadata on each variable's l2g_scale_type (adds a
    landunit_mask attribute) (#1343)

(4) Use python3 in more shebang lines - needed to run python unit tests
    on cheyenne

(5) New compset naming for IG compsets (#1289)

(6) Remove calculation of fun_cost_fix that is overwritten
    (#1115)

(7) Bypass grid-level water mass check when fates hydro is active
    (#1334)

(8) Remove some dead code (#1333)

- Resolves #1115 (overwrite fun_cost_fix)
- Resolves #1289 (After updating to cism2_1_76 or later,
  change compsets involving CISM)
- Resolves #1294 (Replace istice_mec with istice)
- Resolves #1333 (Remove some dead code)
- Resolves #1343 (Add landunit_mask (formerly l2g_scale_type)
  metadata to history file)
glemieux added a commit to ckoven/ctsm that referenced this issue Apr 20, 2021
@glemieux
Merge tag 'ctsm5.1.dev035' into snow_occlusion_ctsm
51d3145 
Misc bfb enhancements and fixes

(1) If CISM is running over Antarctica, use virtual glacier columns over
    Antarctica

(2) Remove "mec" from some glacier/ice variable names (it is misleading
    to have "mec" in variable names when the ice landunit can actually
    have multiple columns *or* a single column) (ESCOMP#1294)

(3) Add history file metadata on each variable's l2g_scale_type (adds a
    landunit_mask attribute) (ESCOMP#1343)

(4) Use python3 in more shebang lines - needed to run python unit tests
    on cheyenne

(5) New compset naming for IG compsets (ESCOMP#1289)

(6) Remove calculation of fun_cost_fix that is overwritten
    (ESCOMP#1115)

(7) Bypass grid-level water mass check when fates hydro is active
    (ESCOMP#1334)

(8) Remove some dead code (ESCOMP#1333)
ekluzek added a commit to jedwards4b/ctsm that referenced this issue Apr 21, 2021
@ekluzek
Merge tag 'ctsm5.1.dev035' into neon_compsets
7d7751a 
Misc bfb enhancements and fixes

(1) If CISM is running over Antarctica, use virtual glacier columns over
    Antarctica

(2) Remove "mec" from some glacier/ice variable names (it is misleading
    to have "mec" in variable names when the ice landunit can actually
    have multiple columns *or* a single column) (ESCOMP#1294)

(3) Add history file metadata on each variable's l2g_scale_type (adds a
    landunit_mask attribute) (ESCOMP#1343)

(4) Use python3 in more shebang lines - needed to run python unit tests
    on cheyenne

(5) New compset naming for IG compsets (ESCOMP#1289)

(6) Remove calculation of fun_cost_fix that is overwritten
    (ESCOMP#1115)

(7) Bypass grid-level water mass check when fates hydro is active
    (ESCOMP#1334)

(8) Remove some dead code (ESCOMP#1333)

 Conflicts:
	bld/unit_testers/build-namelist_test.pl
ekluzek added a commit to ekluzek/CTSM that referenced this issue Apr 29, 2021
@ekluzek
Merge tag 'ctsm5.1.dev035' into add_mizuRoute
3764f91 
Misc bfb enhancements and fixes

(1) If CISM is running over Antarctica, use virtual glacier columns over
    Antarctica

(2) Remove "mec" from some glacier/ice variable names (it is misleading
    to have "mec" in variable names when the ice landunit can actually
    have multiple columns *or* a single column) (ESCOMP#1294)

(3) Add history file metadata on each variable's l2g_scale_type (adds a
    landunit_mask attribute) (ESCOMP#1343)

(4) Use python3 in more shebang lines - needed to run python unit tests
    on cheyenne

(5) New compset naming for IG compsets (ESCOMP#1289)

(6) Remove calculation of fun_cost_fix that is overwritten
    (ESCOMP#1115)

(7) Bypass grid-level water mass check when fates hydro is active
    (ESCOMP#1334)

(8) Remove some dead code (ESCOMP#1333)

 Conflicts:
	Externals.cfg
	Externals_cime.cfg
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billsacks billsacks

Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@billsacks @samsrabin