Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change from more_vertlayers to equivalent soil_layerstruct causes test failures #123

Closed
ekluzek opened this issue Dec 16, 2017 · 2 comments
Closed

change from more_vertlayers to equivalent soil_layerstruct causes test failures #123

ekluzek opened this issue Dec 16, 2017 · 2 comments
Labels
bug something is working incorrectly

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 16, 2017

Ben Andre < andre > - 2015-10-10 21:52:09 -0600
Bugzilla Id: 2232
Bugzilla CC: rfisher,

clm4_5_3_r138 removes the namelist option more_vertlayers. It is replaced by the equivalent:

soil_layerstruct = '23SL_3.5m'

I updated the vrtlay testmod and most of the tests using it passed bit for bit with the baseline. The following tests continued to fail:

ERP_Ld5.f09_g16.ICLM45VIC.yellowstone_pgi.clm-vrtlay
ERP_D_Ld5.f09_g16.ICLM45VIC.yellowstone_intel.clm-vrtlay

The land log reports:

Reading initial conditions from
/glade/p/cesmdata/cseg/inputdata/lnd/clm2/initdata_map/clmi.ICRUCLM45SP.2000-01-01.0.9x1.25_g1v6_simyr2000_c141226.nc
(GETFIL): attempting to find local file
clmi.ICRUCLM45SP.2000-01-01.0.9x1.25_g1v6_simyr2000_c141226.nc (GETFIL): using
/glade/p/cesmdata/cseg/inputdata/lnd/clm2/initdata_map/clmi.ICRUCLM45SP.2000-01-01.0.9x1.25_g1v6_simyr2000_c141226.nc
Reading restart dataset
check_dim ERROR: mismatch of input dimension 15
with expected value 30 for variable levgrnd
ERROR:
ERROR in /glade/p/work/andre/dlawren_accel_spinup/accel_spinup_dr/components/clm/src/main/ncdio_pio.F90.in at line 358

It seems that there is a conflict between the new soil layer structure and the initial conditions file. This should be the same as the original more_vertlayers, I'm not sure at the moment why the original test ran.

These are both VIC tests, so the error may have something to do with that instead?

Maybe these would be a good test for the interp of vertical soil structure?
@ekluzek ekluzek added this to the clm5 milestone Dec 16, 2017
@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 16, 2017

Ben Andre < andre > - 2015-10-10 21:53:01 -0600

Marking these tests as expected failures for now.

@ekluzek ekluzek removed this from the clm5 milestone Aug 4, 2019
@ekluzek ekluzek added the bug something is working incorrectly label Aug 4, 2019
@ekluzek
Copy link
Collaborator Author

ekluzek commented Aug 4, 2019

This must be working now, as it's no longer in the expected fails.

@ekluzek ekluzek closed this as completed Aug 4, 2019
samsrabin pushed a commit to samsrabin/CTSM that referenced this issue Apr 19, 2024
@jedwards4b
Merge pull request ESCOMP#123 from jedwards4b/jedwards/solar_zenith_a…
39f79b4 
…ngle_correction
samsrabin pushed a commit to samsrabin/CTSM that referenced this issue Apr 19, 2024
@billsacks
Revert "Merge pull request ESCOMP#123 from jedwards4b/jedwards/solar_…
bae31f4 
…zenith_angle_correction"

This reverts commit 39f79b4, reversing
changes made to 4ebc156.
samsrabin pushed a commit to samsrabin/CTSM that referenced this issue Apr 19, 2024
@billsacks
Merge pull request ESCOMP#148 from billsacks/backout_123
2ee28ac 
Revert PR ESCOMP#123

### Description of changes

PR ESCOMP#123 (solar zenith angle correction) led to exact restart failures in some situations: see ESCOMP#144. This PR backs out the changes from ESCOMP#123 .

### Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed (include github issue #): Temporarily deals with ESCOMP#144.

Are there dependencies on other component PRs (if so list): no

Are changes expected to change answers (bfb, different to roundoff, more substantial): more substantial. I have verified that this brings answers back to being bfb with those in cdeps0.12.35 (i.e., prior to ESCOMP#123) via a run of the aux_clm test suite.

Any User Interface Changes (namelist or namelist defaults changes): no

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): aux_clm

Hashes used for testing: billsacks/ctsm@3fd7f6fbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something is working incorrectly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ekluzek