Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): slash commands #34

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Mesteery
Copy link
Member

@Mesteery Mesteery commented Jul 11, 2021

image

TODO

  • Command's options
  • split commits
  • CommandInteraction abstraction and better options ("slash command arguments") typings (?)
  • suggestions, etc.

@Mesteery Mesteery marked this pull request as draft July 11, 2021 14:52
@Mesteery Mesteery force-pushed the feat/slash-commands branch 2 times, most recently from c4576a5 to 011af73 Compare July 11, 2021 19:24
@Mesteery
Copy link
Member Author

image

@Mesteery Mesteery force-pushed the feat/slash-commands branch 6 times, most recently from 005f4a4 to 2da9180 Compare July 11, 2021 21:15
@Mesteery Mesteery marked this pull request as ready for review July 11, 2021 21:16
@Mesteery Mesteery changed the title wip: feat(framework): slash commands feat(framework): slash commands Jul 11, 2021
@Mesteery Mesteery force-pushed the feat/slash-commands branch 4 times, most recently from ada53f3 to 919574f Compare July 11, 2021 21:45
@RomainLanz
Copy link
Member

Je ne suis pas en faveur d'utiliser une version dev de discord.js en production.

@Mesteery Mesteery marked this pull request as draft July 25, 2021 22:43
@Mesteery Mesteery marked this pull request as ready for review August 6, 2021 14:19
Copy link
Member Author

@Mesteery Mesteery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Malheureusement je ne peux pas bloquer ma propre PR)
Je ne suis pas très content de la façon dont les slashs commandes sont enregistrés auprès de Discord. Je pense en particulier qu'on devrait plutôt utiliser un outil "externe" pour enregistrer les commandes (juste qui n'est pas lancé à chaque redémarrage du bot), comme pour lancer des migrations. Si vous êtes d'accord/avez des meilleurs idées, je suis preneur.

@targos
Copy link
Member

targos commented Aug 8, 2021

Je pense en particulier qu'on devrait plutôt utiliser un outil "externe" pour enregistrer les commandes (juste qui n'est pas lancé à chaque redémarrage du bot), comme pour lancer des migrations.

Je suis d'accord. Je peux setup Heroku pour qu'il exécute une commande au moment de déployer une nouvelle version.

package-lock.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Mesteery Mesteery marked this pull request as ready for review August 10, 2021 17:01
@Mesteery Mesteery requested a review from targos August 10, 2021 17:03
@Mesteery Mesteery marked this pull request as draft November 1, 2021 11:48
@Xstoudi
Copy link
Member

Xstoudi commented Oct 7, 2022

Avec les dernières news de Discord concernant les bots et les commandes legacy + vu l'AFK sur la PR, je pense qu'on peut fermer la PR.

@Purexo
Copy link
Contributor

Purexo commented Oct 7, 2022

Oui, à fermer.
Et ce pencher sur le sujet des commandes le jour ou on aura des idées de commandes à intégrer au bot.

Pour le moment le bot ce content de tâches Cron et de vérification de format de message

@Xstoudi Xstoudi closed this Oct 10, 2022
@Xstoudi Xstoudi reopened this Oct 10, 2022
@targos targos removed their request for review July 11, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants