Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [C4] Add Gas optimization fixes #235

Merged
merged 3 commits into from
Sep 26, 2023
Merged

chore: [C4] Add Gas optimization fixes #235

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2b98c9
chore: [C4] Add Gas optimization fixes
YamenMerhi Aug 31, 2023
cc252c4
chore: add natspec about `msg.value` in delegatecall loop
YamenMerhi Sep 26, 2023
1eeaf98
test: add more test to pass coverage
YamenMerhi Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions implementations/contracts/custom/OwnableUnset.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,8 @@ abstract contract OwnableUnset {
*/
function _setOwner(address newOwner) internal virtual {
if (newOwner != owner()) {
address oldOwner = _owner;
emit OwnershipTransferred(_owner, newOwner);
_owner = newOwner;
emit OwnershipTransferred(oldOwner, newOwner);
}
}
}
Loading