Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: mark setData(..) as payable #197

Merged
merged 8 commits into from
Mar 13, 2023
Merged

refactor!: mark setData(..) as payable #197

merged 8 commits into from
Mar 13, 2023

Conversation

YamenMerhi
Copy link
Collaborator

@YamenMerhi YamenMerhi commented Mar 13, 2023

What does this PR introduce?

BREAKING CHANGE ⚠️ ⚠️

  • mark setData(..) as payable
  • Add tests for reverting when sending value

docs/ERC-725.md Outdated Show resolved Hide resolved
@YamenMerhi YamenMerhi changed the title refactor: mark setData(..) as payable refactor!: mark setData(..) as payable Mar 13, 2023
implementations/contracts/ERC725YCore.sol Show resolved Hide resolved
implementations/contracts/interfaces/IERC725Y.sol Outdated Show resolved Hide resolved
implementations/contracts/interfaces/IERC725Y.sol Outdated Show resolved Hide resolved
@CJ42 CJ42 merged commit 1beae99 into develop Mar 13, 2023
@CJ42 CJ42 deleted the payable/ERC725Y branch March 13, 2023 15:09
andyogaga pushed a commit to andyogaga/ERC725 that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants