Added support for workbooks that has duplicate defined names. The las…

…t name in the load order will be used. Issue #37.
EPPlusSoftware · Feb 21, 2020 · 3548252 · 3548252
1 parent f6b1b1f
commit 3548252
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 2 deletions.
diff --git a/src/EPPlus/ExcelNamedRangeCollection.cs b/src/EPPlus/ExcelNamedRangeCollection.cs
@@ -68,8 +68,16 @@ public ExcelNamedRange Add(string Name, ExcelRangeBase Range)
 
         private void AddName(string Name, ExcelNamedRange item)
         {
-            _dic.Add(Name, _list.Count);
-            _list.Add(item);
+            if(_dic.ContainsKey(Name)) //Excel allows duplicate names on load. Duplicates can be generated by for example Libre Office print areas. Always pick the last in the list.
+            {
+                _list.RemoveAt(_dic[Name]);
+                _list.Insert(_dic[Name], item);
+            }
+            else
+            {
+                _dic.Add(Name, _list.Count);
+                _list.Add(item);
+            }
         }
         /// <summary>
         /// Add a defined name referencing value

diff --git a/src/EPPlusTest/Core/Worksheet/WorksheetRangeInsertDeleteTests.cs b/src/EPPlusTest/Core/Worksheet/WorksheetRangeInsertDeleteTests.cs
@@ -39,6 +39,7 @@ public void ValidateFormulasAfterInsertRow()
             ws.InsertRow(3, 1);
 
             //Assert
+            Assert.AreEqual(1, ws._sharedFormulas.Count);
             Assert.AreEqual("Sum(C6:C11)", ws.Cells["A1"].Formula);
             Assert.AreEqual("Sum(C6:C11)", ws.Cells["B1"].Formula);
             Assert.AreEqual("Sum(C7:C12)", ws.Cells["B2"].Formula);

diff --git a/src/EPPlusTest/Issues.cs b/src/EPPlusTest/Issues.cs
@@ -1075,5 +1075,16 @@ public void Issue464()
                 }
             }
         }
+        [TestMethod]
+        public void Issue625()
+        {
+            using (var p = OpenTemplatePackage("multiple_print_areas.xlsx"))
+            {
+
+                var workSheet = p.Workbook.Worksheets[0];
+
+                SaveWorkbook("Issue625.xlsx", p);
+            }
+        }
     }
 }