This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2019
Closed
…th 'repostory_inactive'
…0c1fe13cd411b0fa6f942cd4a50de7a5ba49351
3 tasks
This was referenced Aug 26, 2019
zreyn
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. Just one comment to consider, but not required.
|
||
FULL_TAG=${FULL_TAG:-eosio/ci-contracts-builder:base-ubuntu-18.04-$EOSIO_COMMIT} | ||
ARGS=${ARGS:-"--rm -v $(pwd):$MOUNTED_DIR"} | ||
CDT_COMMANDS="apt-get install -y wget && wget -q $CDT_URL -O eosio.cdt.deb && dpkg -i eosio.cdt.deb && export PATH=/usr/opt/eosio.cdt/$CDT_VERSION/bin:\\\$PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to get this installed in the base image instead?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
We have decided to run community builds in Travis CI for EOSIO repositories because Travis provides free CICD infrastructure to open-source projects so, if a community member were to inject malicious code into a pull request, it would compromise Travis instead of Block.one.
This branch is considered stable and is being used to collect metrics, so please treat this like develop and make changes on branches off of
trav-poc
and test them before merging them back in.Changes:
See Also
release/1.6.x
master
develop
Deployment Changes
None.
API Changes
None.
Documentation Additions
None.